Suppress CodeQL [SM02167]#2566
Open
shaahji wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to suppress a CodeQL alert related to using hashlib.md5 in olive/passes/diffusers/lora.py, clarifying that the computed hash is only used to generate deterministic cache directory names (not for any security-sensitive purpose).
Changes:
- Adds an inline comment intended to suppress CodeQL alert SM02167 for an
md5usage. - Reformats the
prompt_hashcomputation into a multi-line expression.
Computed hash is used solely for creating uniques directory names in cache, not a security-sensitive usage.
shaahji
force-pushed
the
shaahji/CodeQL_SM02167
branch
from
aaa4d28 to
fdf28ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress CodeQL [SM02167]
Computed hash is used solely for creating uniques directory names in cache, not a security-sensitive usage.
Checklist before requesting a review
lintrunner -a(Optional) Issue link