Repository navigation
Reduce UNT0043 false positives for platform and version guards - #505
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jb Evain (jbevain)
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Short description of what this resolves
UNT0043 can mistake intentionally inactive platform and Unity-version symbols for typos because it only compares them with symbols enabled in the current build. Reported examples include
UNITY_6000_4_OR_NEWERandUNITY_6000_5_OR_NEWERbeing suggested asUNITY_6000_0_OR_NEWER, andUNITY_PS4being suggested asUNITY_64.Make detection more conservative without maintaining a catalog of Unity platforms or versions. This remains a heuristic: valid optional symbols can still resemble enabled symbols, and typos for inactive platforms may go undetected.
Changes proposed in this pull request
UNITY_X,UNITY_X_Y,UNITY_X_Y_Z, andUNITY_X_Y_OR_NEWERversion symbols independently of the installed Unity version.Validation
ConditionalCompilationSymbolTypoTestscases successfully.