feat(VariantBasedInjection): LazyVariantServiceProvider with Keyed DI#605
Open
Stepami wants to merge 7 commits into
Open
feat(VariantBasedInjection): LazyVariantServiceProvider with Keyed DI#605Stepami wants to merge 7 commits into
Stepami wants to merge 7 commits into
Conversation
VariantServiceProvider uses sp to get keyed services BREAKING CHANGE: behavioural: keyed services registration needed unless we override descriptors for backward comp
Author
|
@microsoft-github-policy-service agree |
rename keyedServiceProvider to serviceProvider for clarity
Author
|
I just thought that to avoid BC i could introduce |
added 4 commits
May 19, 2026 15:26
keyed di impl in a separate class Closes microsoft#564
keyed di impl separate class
Extension method impl && tests Closes microsoft#564
Added notes about impls handling to highlight difference with lazy one
Stepami
changed the title
Author
|
@zhiyuanliang-ms could you please take a look? Managed to avoid BC through making Keyed DI implementation as the new feature |
Stepami
changed the title
use DI package as transitive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new class
LazyVariantServiceProvideruses sp to get keyed servicesWhy this PR?
Keyed DI can be used in FeatureManagement library as package-provided solution despite netstandard targeting
Visible Changes
LazyVariantServiceProviderclassWithLazyVariantServicedi extension method