Repository navigation
Make DT run results navigable on GitHub - #1345
Merged
Jake Bailey (jakebailey) merged 2 commits intoOct 3, 2026
Merged
Conversation
DT diagnostics need direct links to the tested sources and project configs so compiler regressions are easier to investigate. Large runs also need readable results across comments, with complete linked output available in the build logs.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation is well-scoped, safely handles output formatting and limits, and has comprehensive automated coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Adds commit-pinned GitHub navigation to DT test results while preserving complete diagnostics in Azure logs.
Changes:
- Enriches failures with package, project, and diagnostic links.
- Safely formats, escapes, truncates, and paginates GitHub comments.
- Adds comprehensive result-linking and publishing tests.
| File | Description |
|---|---|
.azure-pipelines/scripts/run-typescript-pr-dt.sh |
Enriches failure artifacts with links. |
.changeset/friendly-dt-links.md |
Documents the patch release. |
packages/dtslint-runner/package.json |
Adds the GitHub-link dependency. |
packages/dtslint-runner/src/add-github-links.ts |
Generates pinned navigation metadata. |
packages/dtslint-runner/src/post-results.ts |
Formats, paginates, logs, and posts results. |
packages/dtslint-runner/test/results.test.ts |
Tests linking and result publication. |
pnpm-lock.yaml |
Locks the new dependency. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Errors resolved by the branch should remain visible without marking the run as needing attention. Reserve that status for new or changed branch errors.
Wesley Wigham (weswigham)
approved these changes
Oct 2, 2026
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Fancy, nice.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've always wanted this.
Example https://gist.github.com/jakebailey/3532db428b3fdc9316f5a047ee875efe