Repository navigation
Conversation
The schema-version tests from #43 seeded and asserted on build-2025/ignite-2025, which #64 removed from config. ensureCache() no longer revalidates build-2025 and fetches the unseeded ignite-2026. Seed only the configured 2026 events instead. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the test-only update aligning cache schema fixtures with supported 2026 events.
No open issues 🎉
What changed in this PR
Updates cache schema tests to match the supported 2026 events, resolving stale assumptions left by the removal of the 2025 catalogs. Changes are test-only; no CLI behavior or plugin versions change.
Changes:
- Seeds Build 2026 and Ignite 2026 caches in both schema tests.
- Strengthens the outdated-schema test by checking the exact Build 2026 endpoint while retaining full-GET and metadata assertions.
| File | Description |
|---|---|
cli/test/cache.test.ts |
Aligns schema-test fixtures with supported events and verifies the expected fetch endpoint. |
Review effort: Balanced
Without schemaVersion the CLI treats the fixture cache as outdated and does a full live GET, replacing the 2025 fixture sessions with live build-2026 data so the fixture session code lookup fails. This was hidden on main because the cache tests failed first. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainat 768c8c8 has two related breaks left by combining #43 and #64. The first broke our internal npm test pipeline when it built@microsoft/events-cli@0.3.3:cli/test/cache.test.ts(automatic cache revalidation) fail:readMeta('build-2025').schemaVersionstays1(expectedCACHE_SCHEMA_VERSION).fetchis called once forhttps://aka.ms/ignite2026-session-info.npm run smoke:fixturefails withExpected one session for BRK212. This was hidden onmainbecause the test step fails first.Root cause
build-2025,ignite-2025, andbuild-2026, and test 1 asserts onbuild-2025.cli/src/config.tsnow configures onlybuild-2026andignite-2026, and the smoke script now seeds the fixture asbuild-2026.main:ensureCache()no longer revalidatesbuild-2025, so its schema version stays at 1.ignite-2026isn't seeded, soensureCache()fetches it.schemaVersion, so the CLI treats it as outdated and does a full live GET. Before Remove retired 2025 events and bump CLI to 0.3.3 #64 thebuild-2025endpoint returned 404 and the CLI fell back to the fixture cache. Now the livebuild-2026catalog replaces the fixture sessions, so the fixture session codeBRK212is no longer found.Changes (tests and smoke script only)
build-2026at schema v1 andignite-2026at the current schema. It now asserts:build-2026endpointbuild-2026meta is updated toCACHE_SCHEMA_VERSIONwithlastCheckStatusupdatedbuild-2026andignite-2026atCACHE_SCHEMA_VERSIONand asserts that nothing is fetched.cli/scripts/smoke-fixture.mjs: writesschemaVersion: CACHE_SCHEMA_VERSION(imported fromdist/data/cache.js) into the fixture meta, so the smoke test uses the fixture cache instead of live data.No CLI source,
SKILL.md, or plugin manifest changes, so no version bump is needed. Otherbuild-2025references incli/test/(normalize.test.ts,search.test.ts) only label the static fixture in pure-function tests. They don't depend on the configured events, so I left them unchanged.smoke:m365runs offline (cache read-only), so it doesn't needschemaVersion.Validation (from
cli/)npx vitest run test\cache.test.ts(before fix)npm run smoke:fixture(before fix)Expected one session for BRK212(reproduced)npm run buildnpx vitest run test\cache.test.tsnpm testnpm run smoke:fixturenpm run smoke:m365npm run smoke:m365 -- --package(needsatk) andnpm run smoke:livewere not run locally; CI covers them.