Skip to content

[API tests] Re-enable remaining API tests that NAV runs - #12819

Open
Prangshuman Das (t-prda) wants to merge 1 commit into
features/646383-stack-d9-tenant-refreshfrom
features/646383-stack-d10-remaining-api-tests
Open

Prangshuman Das (t-prda) wants to merge 1 commit into
features/646383-stack-d9-tenant-refreshfrom
features/646383-stack-d10-remaining-api-tests

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review focus: deletions in src/DisabledTests only (47 entries, no code changes).

Re-enables the API tests that BCApps still disables but NAV runs (they are not in NAV master's App/DisabledTests or PartnerDisabledTests). "API tests" means the methods that call Library - Graph Mgt web-service methods; the earlier layers covered Expense and APIV1/APIV2.

Codeunit Tests re-enabled
135549 Report Inbox API E2E 16
148185 Sustainability API Tests 9
135528 WFWH Subscription E2E Tests 6
135548 API Routes E2E 5
135547 Webhook Logs E2E 5
139741 VAT Group Sub. Status Test 3 (NAV still disables the other 4)
148018 IRS 1099 API Tests 1
139972 Qlty. Tests - Inspections API whole codeunit (*)
134920 ERM General Journal UT 1 (TestCreateGenJnlBatchPostWebService); the other non-API disabled tests stay excluded

API tests that NAV also disables (15) stay disabled.

Validation: the JSON files still parse. CI on this PR is the validation. If a re-enabled test needs a fixture fix like D1–D8, it will be added here or disabled again with a reason.

Related: AB#646383

Stack (each PR shows only its own layer; merge bottom first)

  1. [API tests] Default to web service key authentication #12674 A: web service key auth (base: main)
  2. [Expense tests] Re-enable Expense Agent API tests #12675 B: Expense API tests + clean test codeunit execution
  3. [API tests] Re-enable APIV1 and APIV2 API tests #12676 C: re-enable APIV1/APIV2 API tests
  4. [API tests] Simplify API test web service key handling #12890 Review fixes for A: simplify web service key handling
  5. Area fixes: [API tests] Ensure VAT posting setup in API document fixtures #12677 D1 VAT fixtures → [API tests] Ensure cancellation reason codes in API sales document tests #12678 D2 cancellation reasons → [API tests] Handle localized purchase invoice payment discounts in APIV1 tests #12679 D3 localized discounts → [API tests] Set sales quote document and posting dates in API tests #12680 D4 quote dates → [API tests] Assign a number series to API vendor payment journals #12681 D5 journal numbering → [API tests] Ignore localized fields in API document comparisons #12682 D6 field comparison → [API tests] Return shipment PDF selection and pdfDocument test isolation #12683 D7 PDF documents → [API tests] Improve APIV1 fixture and verification reliability #12684 D8 APIV1 reliability → [API tests] End tenant sessions before dropping clean test tenant databases #12777 D9 tenant refresh → this PR, D10 remaining API tests

@t-prda
Prangshuman Das (t-prda) added this pull request to stack #12697 October 14, 2026 12:06
@t-prda Prangshuman Das (t-prda) added the Team: Finance GitHub request for Finance area label Oct 14, 2026
@github-actions github-actions Bot added Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction Team: Other GitHub request for other area than SCM, Finance or Integration and removed Team: Finance GitHub request for Finance area labels Oct 14, 2026
@t-prda
Prangshuman Das (t-prda) force-pushed the features/646383-stack-d10-remaining-api-tests branch from 4908729 to 0a12600 Compare October 14, 2026 12:58
@t-prda
Prangshuman Das (t-prda) requested a review from a team October 14, 2026 12:58
@github-actions github-actions Bot added this to the Version 30.0 milestone Oct 14, 2026
@t-prda
Prangshuman Das (t-prda) requested a review from a team October 14, 2026 14:05
@t-prda
Prangshuman Das (t-prda) force-pushed the features/646383-stack-d10-remaining-api-tests branch from 0a12600 to a3cdef5 Compare October 14, 2026 14:05
@t-prda
Prangshuman Das (t-prda) removed this pull request from stack #12697 October 15, 2026 08:59
@t-prda
Prangshuman Das (t-prda) added this pull request to stack #12891 October 15, 2026 09:00
@t-prda
Prangshuman Das (t-prda) force-pushed the features/646383-stack-d10-remaining-api-tests branch from a3cdef5 to e9f520d Compare October 15, 2026 09:02
Re-enable the 47 API tests that BCApps disables but NAV runs: Report Inbox API E2E,
Sustainability API Tests, WFWH Subscription E2E, API Routes E2E, Webhook Logs E2E,
VAT Group Sub. Status, IRS 1099 API, Quality Management Inspections API, and the
general journal web service test.

AB#646383

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
@t-prda
Prangshuman Das (t-prda) force-pushed the features/646383-stack-d10-remaining-api-tests branch from e9f520d to 9a29939 Compare October 15, 2026 12:56

This branch was successfully deployed

1 active (outdated) deployment
triage — 49087292 Deployed Oct 14, 2026 by t-prda via Classify team ownership #7839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction Team: Other GitHub request for other area than SCM, Finance or Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant