Skip to content

[API tests] Ensure cancellation reason codes in API sales document tests #12678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prangshuman Das (t-prda) wants to merge 1 commit into from
Open

[API tests] Ensure cancellation reason codes in API sales document tests #12678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV1/test/src/APIV1SalesCreditMemosE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,12 +816,17 @@ codeunit 139728 "APIV1 - Sales Credit Memos E2E"

local procedure CreateCorrectiveSalesCreditMemo(var SalesCrMemoHeader: Record "Sales Cr.Memo Header")
var
ReasonCode: Record "Reason Code";
SalesInvoiceHeader: Record "Sales Invoice Header";
SalesHeader: Record "Sales Header";
InvoiceCode: Code[20];
begin
LibrarySales.CreateSalesInvoice(SalesHeader);
ModifySalesHeaderPostingDate(SalesHeader, WORKDATE());
EnsureReasonCode();
ReasonCode.FindFirst();
SalesHeader.Validate("Reason Code", ReasonCode.Code);
SalesHeader.Modify(true);
InvoiceCode := LibrarySales.PostSalesDocument(SalesHeader, false, true);
SalesInvoiceHeader.Get(InvoiceCode);
Commit();
Expand All @@ -830,6 +835,16 @@ codeunit 139728 "APIV1 - Sales Credit Memos E2E"
SalesCrMemoHeader.FindFirst();
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateDraftSalesCreditMemo(var SalesHeader: Record "Sales Header")
begin
LibrarySales.CreateSalesCreditMemo(SalesHeader);
Expand Down
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV1/test/src/SalesInvoicesE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,6 +930,7 @@ codeunit 139709 "Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -969,6 +970,7 @@ codeunit 139709 "Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -1292,9 +1294,22 @@ codeunit 139709 "Sales Invoices E2E"
local procedure CreateCancelledSalesInvoice(var SalesInvoiceHeader: Record "Sales Invoice Header")
begin
CreatePostedSalesInvoice(SalesInvoiceHeader);
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();
Commit();
Comment thread
t-prda marked this conversation as resolved.
Comment thread
t-prda marked this conversation as resolved.
CODEUNIT.Run(CODEUNIT::"Correct Posted Sales Invoice", SalesInvoiceHeader);
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateSalesInvoices(var InvoiceID1: Text; var InvoiceID2: Text)
var
SalesInvoiceHeader: Record "Sales Invoice Header";
Expand Down
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV2/test/src/APIV2SalesCreditMemosE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,11 +798,16 @@ codeunit 139828 "APIV2 - Sales Credit Memos E2E"

local procedure CreateCorrectiveSalesCreditMemo(var SalesCrMemoHeader: Record "Sales Cr.Memo Header")
var
ReasonCode: Record "Reason Code";
SalesInvoiceHeader: Record "Sales Invoice Header";
SalesHeader: Record "Sales Header";
InvoiceCode: Code[20];
begin
LibrarySales.CreateSalesInvoice(SalesHeader);
EnsureReasonCode();
ReasonCode.FindFirst();
SalesHeader.Validate("Reason Code", ReasonCode.Code);
SalesHeader.Modify(true);
InvoiceCode := LibrarySales.PostSalesDocument(SalesHeader, false, true);
SalesInvoiceHeader.Get(InvoiceCode);
Commit();
Expand All @@ -811,6 +816,16 @@ codeunit 139828 "APIV2 - Sales Credit Memos E2E"
SalesCrMemoHeader.FindFirst();
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateDraftSalesCreditMemo(var SalesHeader: Record "Sales Header")
begin
LibrarySales.CreateSalesCreditMemo(SalesHeader);
Expand Down
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV2/test/src/APIV2SalesInvoicesE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,7 @@ codeunit 139809 "APIV2 - Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -998,6 +999,7 @@ codeunit 139809 "APIV2 - Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -1359,9 +1361,22 @@ codeunit 139809 "APIV2 - Sales Invoices E2E"
local procedure CreateCancelledSalesInvoice(var SalesInvoiceHeader: Record "Sales Invoice Header")
begin
CreatePostedSalesInvoice(SalesInvoiceHeader);
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();
Commit();
Comment thread
t-prda marked this conversation as resolved.
Comment thread
t-prda marked this conversation as resolved.
CODEUNIT.Run(CODEUNIT::"Correct Posted Sales Invoice", SalesInvoiceHeader);
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateSalesInvoices(var InvoiceID1: Text; var InvoiceID2: Text)
var
SalesInvoiceHeader: Record "Sales Invoice Header";
Expand Down
25 changes: 0 additions & 25 deletions src/DisabledTests/_Exclude_APIV1__Tests/_Exclude_APIV1__Tests.DisabledTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,4 @@
[
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
"method": "TestActionCancelAndSendInvoice"
},
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
"method": "TestActionCancelInvoice"
},
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
"method": "TestActionSendCancelledInvoice"
},
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
Expand All @@ -39,16 +24,6 @@
"codeunitName": "APIV1 - Sales Quotes E2E",
"method": "TestCreateQuoteThroughPageAndAPI"
},
{
"codeunitId": 139728,
"codeunitName": "APIV1 - Sales Credit Memos E2E",
"method": "TestActionCancelAndSendCorrectiveCreditMemo"
},
{
"codeunitId": 139728,
"codeunitName": "APIV1 - Sales Credit Memos E2E",
"method": "TestActionCancelCorrectiveCreditMemo"
},
{
"codeunitId": 139728,
"codeunitName": "APIV1 - Sales Credit Memos E2E",
Expand Down
25 changes: 0 additions & 25 deletions src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,6 @@
"codeunitName": "APIV2 - Company Info. E2E",
"method": "TestModifyCompanyInformation"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
"method": "TestActionCancelAndSendInvoice"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
"method": "TestActionCancelInvoice"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
"method": "TestActionSendCancelledInvoice"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
Expand All @@ -44,16 +29,6 @@
"codeunitName": "APIV2 - Sales Quotes E2E",
"method": "TestCreateQuoteThroughPageAndAPI"
},
{
"codeunitId": 139828,
"codeunitName": "APIV2 - Sales Credit Memos E2E",
"method": "TestActionCancelAndSendCorrectiveCreditMemo"
},
{
"codeunitId": 139828,
"codeunitName": "APIV2 - Sales Credit Memos E2E",
"method": "TestActionCancelCorrectiveCreditMemo"
},
{
"codeunitId": 139828,
"codeunitName": "APIV2 - Sales Credit Memos E2E",
Expand Down
Loading