[Expense tests] Preserve negative fixtures and posted report identity

[Prangshuman Das (t-prda)]

Scope

AB#646383

Negative-fixture layer above #11451 in native stack #11893.

Re-enable exactly five CU 148339 methods: four DeleteTravelRequestWith*IsBlocked cases and TravelRequestAPIDatesKeepValidation. The two posted-deletion cases overlap upstream AB#650277.

Upstream now contains the expected-error fixture commits and Last Posting No. lookup. This layer therefore keeps those changes rather than duplicating them.

The remaining posted-deletion fix uses a separate CreatePostedTravelRequestReportForDeletion fixture: a normally posted zero-amount line creates real posted history while preserving the zero-net-spend precondition. Only the two deletion tests call it.

The upstream shared posted-report fixture is unchanged. Its six new lifecycle/reapproval callers and two-line history assertions retain their original behavior and exclusions. This PR does not silently claim ownership of those additional AB#650277 cases.

Validation

Exact parent ancestry, file scope, whitespace and exclusion ownership checks pass. This layer's added/removed source lines are unchanged relative to its refreshed parent. Upstream changes are inherited through the main merge, not reverted. Earlier exact-head cumulative artifact evidence is historical after this parent reconciliation; fresh new-head runtime validation is pending. Existing excluded PDF, IN/RU gaps and tolerated-native distinctions remain; no absent/excluded case is claimed passing.

Validation limits

The previous UserPassword HTTP 401/200/401 result is historical after this reconciliation. CU139496 MicrosoftAuthenticationRespectsServerAuthMode still executes all three requests; Windows200/200/200 runtime remains unverified. The workflow clean-codeunit gate stays default-off and uptake stays explicitly enabled. No provider, authentication contract, new public event, NAV selector or foreign NST change was introduced. Excluded PDF cases and absent/excluded country/native cases remain unverified; prior tolerated-native results are not universal passes. The 59 owned re-enabled methods cover the reviewed fixes, not59 distinct product defects. Validation drafts remain Do Not Merge, outside native stack #11893.

Current checkpoint

Head f3b84be776a95f01d73b3d15c11095e9807b03ba, tree 23be54705318d71569258f9c1f5ca2fecd73f397; parent 460383d69ec0dbf780a9501bb2ba6cf696d2c76c.

Forward-integrated captured main bb7111877ff786951b86a1a0f80d8b39b8f5dacd, including upstream CLEAN27 removal 82b11d26c073de93df3aab17434069f72feab640 (PR12066), to align the direct stacked-PR warning gate. The prior direct uptake checkout retained obsolete source while warning-reference run37020063048 used main73d5794e; RU and CH therefore each reported51 additional warnings (36 AA0244,15 AA0218). Main-targeted RU validations already passed with cleaned source. No warning suppression, parameter rename, partial cherry-pick, or comparator change was made.

Local Pester:117 passed, zero failed/skipped at exact workflow, uptake and full heads. Every layer retains its exact owned patch; all changed baseline blobs equal captured main, and all remaining blobs—including exclusions—are unchanged. The23 committed wrappers/shared success-only finalizer, generator removal, current-process credential identity, ACLs, buffer clearing and narrowed platform classifier remain intact; ordinary configured reruns are unchanged.

Accepted cleanup limitation: failed/cancelled runs rely on normal container teardown; no hard-runner-loss guarantee. Normal CI uses per-run disposable credentials, but supplied credentials may differ. Hook logs prove invocation, not necessarily explicit deletion if teardown already removed the file.

Uptake retains the five query-safe URL compositions in CU148343 StandardSubmissionExposesPolicySnapshot, all assertions,8 methods, setup restoration and the single unlimited-approval fixture. Workflow remains default-off; uptake enables clean execution. Auth visibility/provider contracts and HTTP scenario are preserved. Upstream shared Spend Request zero-amount UnitTest semantics and permission cleanup from PR11561 remain unchanged. CU139806 TestGetCompanyAndEnvironmentDescriptions stays excluded pending its original rationale/current NAV verification (PR11741).

Fresh exact-head GitHub CI is pending, not passed. Previous runs are historical for these new commits. Verify all8 activity methods across22 countries if present; Windows runtime and excluded PDF/native coverage remain unverified. Only this captured main was integrated—no repeated baseline chasing. Merged prefix/native stack #11893 and draft/ready states remain unchanged; validation drafts remain Do Not Merge.

[github-actions]

Issue #11561 is not valid. Please make sure you link an issue that exists, is open and is approved.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

This change re-enables five Expense Agent tests and gives the two posted-history deletion cases a dedicated zero-amount posted report fixture. The fixture keeps real posted header and line references while leaving the spent amount at zero.

Posting transfers every expense line into posted history before checking whether its amount is nonzero. The deletion tests therefore reach the intended linked-record guards without relying on an invalid negative-line offset.

Problem-solution fit

Fit: Strong

The change directly removes the invalid offsetting-amount assumption and keeps the broader shared fixture unchanged. The other three re-enabled methods already contain the persistence setup needed for their expected-error checks.

Suggestions

S1 (🟠 Moderate): Validate re-enabled tests on current head
Please run the five re-enabled methods on the current PR head. The cited full test run used a different commit and tree, while the current head's PR build did not complete, so the disabled-test removals are not yet backed by exact-head execution.

Risk assessment and necessity

Risk: The code change is limited to test fixtures and the disabled-test manifest, so it does not alter production behavior or public surfaces. The main remaining risk is test reliability because the successful full run used an earlier tree, although the reviewed target procedures remain unchanged.

Necessity: Re-enabling these tests restores coverage for deletion guards and API date validation. The dedicated fixture is narrow and avoids changing production accounting to satisfy a test assumption.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11452 round=1 by=alexei-dobriansky at=2026-09-28T13:14:21.528Z lastSha=161281001463d24529bc91c3ad0d612229b518a8 reviewKey=d47c1e9388b56d531631740e4ae8d2eeab4dce65e257121e85c2d30ab777b7c5 suggestions=S1@e1be3021

[alexei-dobriansky]

Good Sense Reviewer - Round 2

Recommendation: Accept with Suggestions

What this PR does

The branch was reconciled with its refreshed parent, but the net two-file patch is unchanged from round 1. It still replaces the invalid offsetting-line fixture with a normally posted zero-amount line for the two deletion scenarios and re-enables five tests.

The dedicated fixture continues to create real posted header or line references while keeping the spent amount at zero. This reaches the intended deletion guards without changing production accounting or the broader shared fixture.

Status of previous suggestions

ID	Title	Status	Author response
S1	Validate re-enabled tests on current head	Not addressed	None. The replacement exact-head build is still in progress, so the five methods do not yet have completed current-head execution evidence.

New observations (commits since round 1)

None - the net PR patch is unchanged and the new commits only reconcile the branch with its refreshed stack and baseline.

Risk assessment and necessity

Risk: Production risk remains low because the net change only updates test fixtures and disabled-test metadata. The remaining risk is test reliability: the five methods are enabled, but their exact-head execution has not completed yet.

Necessity: The dedicated zero-amount fixture is needed to create valid posted history without relying on negative non-correction lines or changing production accounting. Re-enabling the five tests restores useful deletion and API-date coverage once current-head validation completes.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11452 round=2 by=alexei-dobriansky at=2026-09-30T22:12:33.161Z lastSha=20f1b95d0e533f0eff29c43abb7d4953bc55eeb4 reviewKey=e719ad6b2e550cd315f9e11e7e35c1f5187b3a1cc2584b6c2a78aee5eb75f492 suggestions=S1@e1be3021:notaddressed parentRound=1