-
Notifications
You must be signed in to change notification settings - Fork 469
[Expense tests] Correct restricted permission assertions #11451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Prangshuman Das (t-prda)
wants to merge
27
commits into
prdas/646383-split-apiv1-reliability
from
features/646383-expense-permission-tests
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8514487
Keep Expense permission observations restricted and assertions execut…
t-prda aef6182
Refresh expense-permission-tests layer with the reviewed auth base
t-prda a181728
Refresh expense-permission-tests layer with the reviewed auth base
t-prda bcb5ddd
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 9b6f42c
Refresh expense-permission-tests layer with the reviewed auth base
t-prda df667ac
Reconcile expense permission tests with upstream Entra coverage
t-prda 4f5edae
Carry expense-permission-tests forward after separating workflow infr…
t-prda a6385e3
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 4751396
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 2142d18
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 4a4b0f8
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 184ed4d
Refresh expense-permission-tests layer with the reviewed auth base
t-prda ef2e003
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 46d60ce
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 08a43f0
Refresh expense-permission-tests layer with the reviewed auth base
t-prda 613fd2f
Reconcile restricted permission observations with upstream setup-role…
t-prda 25cc72b
Propagate removal of uptake-only AL source inspection tests
t-prda 4f59b07
Propagate explicit activity-log fixture approval permission
t-prda 595231b
Propagate refreshed baseline and retain upstream company-description …
t-prda e716055
Propagate platform-race classifier regression fix
t-prda c7af52b
Propagate platform-race classifier regression fix
t-prda c338027
Propagate supported API credential finalizer
t-prda 16828a8
Propagate current baseline and simplified API credential finalizer
t-prda 7c2b4a7
Propagate query-safe policy snapshot API test URLs
t-prda 460383d
Propagate warning-baseline alignment without changing scoped fixes
t-prda f3439a6
Propagate tenant-help correction and isolated policy response buffers
t-prda 40dd7ea
Reconcile captured upstream activity-log coverage while preserving AP…
t-prda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test adds an explicit Commit() but has no TransactionModel attribute, so it uses the test framework's AutoRollback default and can fail at the commit instead of validating the permission-denial behavior. Assign an appropriate transaction model for this committed fixture setup and ensure the test runner provides isolation for the committed data.
Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.47.6