[API tests] Separate APIV1 fixture and verification reliability fixes

[Prangshuman Das (t-prda)]

Scope

AB#646383

Draft follow-up to #11230, based on prdas/646383-split-return-shipment-pdf.

• Identify five posted blank API lines by GUID description and exact record lookup.
• Regenerate RapidStart fixtures per invocation; refresh all three polling loops, correct expected/actual assertion order, and fix the apply-status qualifier.
• Keep G/L journal-template handler state in a codeunit global.
• Enable Foundation setup for the invoice discount-percent scenario.
• Re-enable exactly ten APIV1 methods temporarily quarantined while these business fixes were separated. These were conservative/deferred exclusions, not newly proven failures. RS create/upload were not additionally quarantined.

Lifetime and preservation

Automation initialization keeps workdate first, followed by idempotent authentication-provider selection, per-test cleanup, and sample generation. Removing the guard makes provider selection per invocation; its existing same-provider early return remains intact.

Preserves the shared prefix, all seven earlier API-fix layers, APIV2 wildcards, and all 48 Expense exclusion entries inherited at this layer. Only eight AL files and the APIV1 exclusion manifest change.

Validation

Exact parent ancestry, file scope, whitespace and exclusion ownership checks pass. This layer's added/removed source lines are unchanged relative to its refreshed parent. Upstream changes are inherited through the main merge, not reverted. Earlier exact-head cumulative artifact evidence is historical after this parent reconciliation; fresh new-head runtime validation is pending. Existing excluded PDF, IN/RU gaps and tolerated-native distinctions remain; no absent/excluded case is claimed passing.

Validation limits

The previous UserPassword HTTP 401/200/401 result is historical after this reconciliation. CU139496 MicrosoftAuthenticationRespectsServerAuthMode still executes all three requests; Windows200/200/200 runtime remains unverified. The workflow clean-codeunit gate stays default-off and uptake stays explicitly enabled. No provider, authentication contract, new public event, NAV selector or foreign NST change was introduced. Excluded PDF cases and absent/excluded country/native cases remain unverified; prior tolerated-native results are not universal passes. The 59 owned re-enabled methods cover the reviewed fixes, not59 distinct product defects. Validation drafts remain Do Not Merge, outside native stack #11893.

Current checkpoint

Head b1973cf1bd2f40f58038b95adfae8ff45fd51565, tree 90e607244ddf7ca30b50838338236c11fba423ef; parent 004bf02871e12fec89243265b7bb7aaa34823828.

Forward-integrated captured main bb7111877ff786951b86a1a0f80d8b39b8f5dacd, including upstream CLEAN27 removal 82b11d26c073de93df3aab17434069f72feab640 (PR12066), to align the direct stacked-PR warning gate. The prior direct uptake checkout retained obsolete source while warning-reference run37020063048 used main73d5794e; RU and CH therefore each reported51 additional warnings (36 AA0244,15 AA0218). Main-targeted RU validations already passed with cleaned source. No warning suppression, parameter rename, partial cherry-pick, or comparator change was made.

Local Pester:117 passed, zero failed/skipped at exact workflow, uptake and full heads. Every layer retains its exact owned patch; all changed baseline blobs equal captured main, and all remaining blobs—including exclusions—are unchanged. The23 committed wrappers/shared success-only finalizer, generator removal, current-process credential identity, ACLs, buffer clearing and narrowed platform classifier remain intact; ordinary configured reruns are unchanged.

Accepted cleanup limitation: failed/cancelled runs rely on normal container teardown; no hard-runner-loss guarantee. Normal CI uses per-run disposable credentials, but supplied credentials may differ. Hook logs prove invocation, not necessarily explicit deletion if teardown already removed the file.

Uptake retains the five query-safe URL compositions in CU148343 StandardSubmissionExposesPolicySnapshot, all assertions,8 methods, setup restoration and the single unlimited-approval fixture. Workflow remains default-off; uptake enables clean execution. Auth visibility/provider contracts and HTTP scenario are preserved. Upstream shared Spend Request zero-amount UnitTest semantics and permission cleanup from PR11561 remain unchanged. CU139806 TestGetCompanyAndEnvironmentDescriptions stays excluded pending its original rationale/current NAV verification (PR11741).

Fresh exact-head GitHub CI is pending, not passed. Previous runs are historical for these new commits. Verify all8 activity methods across22 countries if present; Windows runtime and excluded PDF/native coverage remain unverified. Only this captured main was integrated—no repeated baseline chasing. Merged prefix/native stack #11893 and draft/ready states remain unchanged; validation drafts remain Do Not Merge.

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

[github-actions]

Issue #11561 is not valid. Please make sure you link an issue that exists, is open and is approved.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This PR makes the affected APIV1 tests deterministic before re-enabling ten methods. It uses exact record lookup, refreshes asynchronous status reads, regenerates RapidStart fixtures, keeps handler state stable, and enables the required application area. The changes match each failing path and do not alter production code.

Problem-solution fit

Fit: Strong

The reliability changes directly address stale state, ambiguous record selection, and missing setup in the affected tests. The removed exclusions match the corrected methods.

Suggestions

None.

Risk assessment and necessity

Risk: Low because only test code and disabled-test metadata change. The main risk is renewed test instability, but the changed paths match a successful full test run and the exact-head build is green.

Necessity: These fixes restore reliable APIV1 regression coverage. Keeping the methods disabled would leave the affected API scenarios untested.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11322 round=1 by=alexei-dobriansky at=2026-09-28T22:05:14.599Z lastSha=c4983df05e8f5dc952623343950e9b7fd2c703b0 reviewKey=438de1f642ba874a13e4416e0e686ef086b864450687ee36593a8f8a5a63f1bd suggestions=

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

[alexei-dobriansky]

Good Sense Reviewer - Round 2

Recommendation: Accept

What this PR does

The commits since round 1 only reconcile stacked ancestry and upstream baseline changes. The reviewed test and exclusion files are byte-for-byte unchanged, and the net PR diff remains aligned with the corresponding APIV2 patterns.

Status of previous suggestions

None from round 1.

New observations (commits since round 1)

None - no scoped code changed since round 1.

Risk assessment and necessity

Risk: Low because the PR still changes only tests and disabled-test metadata. Fresh exact-head unit-test jobs are queued, but no new scoped change requires a different assessment.

Necessity: The reliability fixes remain needed to restore APIV1 regression coverage without changing production behavior.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11322 round=2 by=alexei-dobriansky at=2026-10-02T22:26:24.5153409Z lastSha=b1973cf1bd2f40f58038b95adfae8ff45fd51565 reviewKey=1864789e07827e3252fc4d0d493a662eac08fed8aecb2d776e6359f97395dc7f suggestions=none parentRound=1