Skip to content

[API tests] Ensure vendor-payment journal number series #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Prangshuman Das (t-prda) wants to merge 5 commits into from
Draft

[API tests] Ensure vendor-payment journal number series #11228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a45509
[API tests] Ensure vendor-payment journal number series
t-prda Oct 5, 2026
1e3eaf5
Inherit complete Expense API re-enablement
t-prda Oct 5, 2026
b300a7c
Inherit captured main and clean Expense-first ancestry
t-prda Oct 5, 2026
77a6c74
Inherit Expense-stage sequencing without source changes
t-prda Oct 5, 2026
202c33b
Inherit existing-manifest sequencing with identical source
t-prda Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@
"codeunitName": "APIV2 - Sales Credit Memos E2E",
"method": "TestCreateCreditMemoThroughPageAndAPI"
},
{
"codeunitId": 139843,
"codeunitName": "APIV2 - Vendor Payments E2E",
"method": "TestCreateVendorPaymentWithoutDocNo"
},
{
"codeunitId": 139851,
"codeunitName": "APIV2 - Purchase Orders E2E",
Expand All @@ -39,11 +34,6 @@
"codeunitName": "APIV2 - Purch. Cr. Memos E2E",
"method": "TestCreateCreditMemoThroughPageAndAPI"
},
{
"codeunitId": 139867,
"codeunitName": "APIV2 - Apply Vendor Ent. E2E",
"method": "TestApplyVendorEntryAppliesPayment"
},
{
"codeunitId": 139928,
"codeunitName": "APIV2 - Purch. Ret. Shpts. E2E",
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/W1/Tests/TestLibraries/LibraryGraphJournalLines.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@ codeunit 130622 "Library - Graph Journal Lines"
begin
JournalName := LibraryUtility.GenerateRandomCode(GenJournalBatch.FieldNo(Name), DATABASE::"Gen. Journal Batch");
LibraryAPIGeneralJournal.EnsureGenJnlBatchExists(GraphMgtJournal.GetDefaultVendorPaymentsTemplateName(), JournalName);
GenJournalBatch.Get(GraphMgtJournal.GetDefaultVendorPaymentsTemplateName(), JournalName);

@github-actions github-actions Bot Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Performance}$

CreateVendorPaymentsJournal calls EnsureGenJnlBatchExists, which already performs a primary-key Get for this template and batch, and then immediately performs the same Get again before checking No. Series. This adds an avoidable database round trip on every helper call; return or pass through the record loaded by the ensure helper, or otherwise combine the existence check and No. Series update into one lookup.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.48.6

if GenJournalBatch."No. Series" = '' then begin
GenJournalBatch.Validate("No. Series", LibraryERM.CreateNoSeriesCode());
GenJournalBatch.Modify(true);
end;
exit(JournalName);
end;

Expand Down
Loading