Skip to content

[API tests] Initialize cancellation reason-code fixtures #11225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Prangshuman Das (t-prda) wants to merge 5 commits into from
Closed

[API tests] Initialize cancellation reason-code fixtures #11225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17423f0
[API tests] Initialize cancellation reason-code fixtures
t-prda Oct 5, 2026
00823ca
Inherit complete Expense API re-enablement
t-prda Oct 5, 2026
367ffb6
Inherit captured main and clean Expense-first ancestry
t-prda Oct 5, 2026
3d88414
Inherit Expense-stage sequencing without source changes
t-prda Oct 5, 2026
004919a
Inherit existing-manifest sequencing with identical source
t-prda Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV1/test/src/APIV1SalesCreditMemosE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,12 +817,17 @@ codeunit 139728 "APIV1 - Sales Credit Memos E2E"

local procedure CreateCorrectiveSalesCreditMemo(var SalesCrMemoHeader: Record "Sales Cr.Memo Header")
var
ReasonCode: Record "Reason Code";
SalesInvoiceHeader: Record "Sales Invoice Header";
SalesHeader: Record "Sales Header";
InvoiceCode: Code[20];
begin
LibrarySales.CreateSalesInvoice(SalesHeader);
ModifySalesHeaderPostingDate(SalesHeader, WORKDATE());
EnsureReasonCode();
ReasonCode.FindFirst();
SalesHeader.Validate("Reason Code", ReasonCode.Code);
SalesHeader.Modify(true);
InvoiceCode := LibrarySales.PostSalesDocument(SalesHeader, false, true);
SalesInvoiceHeader.Get(InvoiceCode);
Commit();
Expand All @@ -831,6 +836,16 @@ codeunit 139728 "APIV1 - Sales Credit Memos E2E"
SalesCrMemoHeader.FindFirst();
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateDraftSalesCreditMemo(var SalesHeader: Record "Sales Header")
begin
LibrarySales.CreateSalesCreditMemo(SalesHeader);
Expand Down
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV1/test/src/SalesInvoicesE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,7 @@ codeunit 139709 "Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -970,6 +971,7 @@ codeunit 139709 "Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -1293,9 +1295,22 @@ codeunit 139709 "Sales Invoices E2E"
local procedure CreateCancelledSalesInvoice(var SalesInvoiceHeader: Record "Sales Invoice Header")
begin
CreatePostedSalesInvoice(SalesInvoiceHeader);
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();
Commit();

@github-actions github-actions Bot Sep 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Testing}$

The newly added Commit executes from TestActionSendCancelledInvoice through CreateCancelledSalesInvoice, but the test codeunit does not declare a TransactionModel for the test. With the default AutoRollback transaction model, the commit path can fail before the API behavior is verified; set the affected test to AutoCommit and run it under an isolation-enabled test runner.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.47.6

CODEUNIT.Run(CODEUNIT::"Correct Posted Sales Invoice", SalesInvoiceHeader);
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateSalesInvoices(var InvoiceID1: Text; var InvoiceID2: Text)
var
SalesInvoiceHeader: Record "Sales Invoice Header";
Expand Down
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV2/test/src/APIV2SalesCreditMemosE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,11 +797,16 @@ codeunit 139828 "APIV2 - Sales Credit Memos E2E"

local procedure CreateCorrectiveSalesCreditMemo(var SalesCrMemoHeader: Record "Sales Cr.Memo Header")
var
ReasonCode: Record "Reason Code";
SalesInvoiceHeader: Record "Sales Invoice Header";
SalesHeader: Record "Sales Header";
InvoiceCode: Code[20];
begin
LibrarySales.CreateSalesInvoice(SalesHeader);
EnsureReasonCode();
ReasonCode.FindFirst();
SalesHeader.Validate("Reason Code", ReasonCode.Code);
SalesHeader.Modify(true);
InvoiceCode := LibrarySales.PostSalesDocument(SalesHeader, false, true);
SalesInvoiceHeader.Get(InvoiceCode);
Commit();
Expand All @@ -810,6 +815,16 @@ codeunit 139828 "APIV2 - Sales Credit Memos E2E"
SalesCrMemoHeader.FindFirst();
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateDraftSalesCreditMemo(var SalesHeader: Record "Sales Header")
begin
LibrarySales.CreateSalesCreditMemo(SalesHeader);
Expand Down
15 changes: 15 additions & 0 deletions src/Apps/W1/APIV2/test/src/APIV2SalesInvoicesE2E.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ codeunit 139809 "APIV2 - Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -997,6 +998,7 @@ codeunit 139809 "APIV2 - Sales Invoices E2E"
DocumentId := SalesInvoiceHeader."Draft Invoice SystemId";

// Special case for AU
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();

Commit();
Expand Down Expand Up @@ -1358,9 +1360,22 @@ codeunit 139809 "APIV2 - Sales Invoices E2E"
local procedure CreateCancelledSalesInvoice(var SalesInvoiceHeader: Record "Sales Invoice Header")
begin
CreatePostedSalesInvoice(SalesInvoiceHeader);
EnsureReasonCode();
LibrarySales.SetDefaultCancelReasonCodeForSalesAndReceivablesSetup();
Commit();

@github-actions github-actions Bot Sep 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Testing}$

The newly added Commit executes from TestActionSendCancelledInvoice through CreateCancelledSalesInvoice, but the test codeunit does not declare a TransactionModel for the test. With the default AutoRollback transaction model, the commit path can fail before the API behavior is verified; set the affected test to AutoCommit and run it under an isolation-enabled test runner.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.47.6

CODEUNIT.Run(CODEUNIT::"Correct Posted Sales Invoice", SalesInvoiceHeader);
end;

local procedure EnsureReasonCode()
var
ReasonCode: Record "Reason Code";
begin
if not ReasonCode.IsEmpty() then
exit;

LibraryERM.CreateReasonCode(ReasonCode);
end;

local procedure CreateSalesInvoices(var InvoiceID1: Text; var InvoiceID2: Text)
var
SalesInvoiceHeader: Record "Sales Invoice Header";
Expand Down
25 changes: 0 additions & 25 deletions src/DisabledTests/_Exclude_APIV1__Tests/_Exclude_APIV1__Tests.DisabledTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,4 @@
[
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
"method": "TestActionCancelAndSendInvoice"
},
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
"method": "TestActionCancelInvoice"
},
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
"method": "TestActionSendCancelledInvoice"
},
{
"codeunitId": 139709,
"codeunitName": "Sales Invoices E2E",
Expand All @@ -34,16 +19,6 @@
"codeunitName": "APIV1 - Sales Quotes E2E",
"method": "TestCreateQuoteThroughPageAndAPI"
},
{
"codeunitId": 139728,
"codeunitName": "APIV1 - Sales Credit Memos E2E",
"method": "TestActionCancelAndSendCorrectiveCreditMemo"
},
{
"codeunitId": 139728,
"codeunitName": "APIV1 - Sales Credit Memos E2E",
"method": "TestActionCancelCorrectiveCreditMemo"
},
{
"codeunitId": 139728,
"codeunitName": "APIV1 - Sales Credit Memos E2E",
Expand Down
25 changes: 0 additions & 25 deletions src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,6 @@
"codeunitName": "APIV2 - Company Info. E2E",
"method": "TestGetCompanyAndEnvironmentDescriptions"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
"method": "TestActionCancelAndSendInvoice"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
"method": "TestActionCancelInvoice"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
"method": "TestActionSendCancelledInvoice"
},
{
"codeunitId": 139809,
"codeunitName": "APIV2 - Sales Invoices E2E",
Expand All @@ -39,16 +24,6 @@
"codeunitName": "APIV2 - Sales Quotes E2E",
"method": "TestCreateQuoteThroughPageAndAPI"
},
{
"codeunitId": 139828,
"codeunitName": "APIV2 - Sales Credit Memos E2E",
"method": "TestActionCancelAndSendCorrectiveCreditMemo"
},
{
"codeunitId": 139828,
"codeunitName": "APIV2 - Sales Credit Memos E2E",
"method": "TestActionCancelCorrectiveCreditMemo"
},
{
"codeunitId": 139828,
"codeunitName": "APIV2 - Sales Credit Memos E2E",
Expand Down
Loading