Fix Snaptchat flickering issue by patching FaceDetector (#3522)#3578
Open
akunterkontrolle wants to merge 1 commit into
Open
Fix Snaptchat flickering issue by patching FaceDetector (#3522)#3578akunterkontrolle wants to merge 1 commit into
akunterkontrolle wants to merge 1 commit into
Conversation
- Replace direct ByteBuffer.array() with duplicate()-based toByteArray() to avoid permanently consuming the buffer position on reuse. - Replace ByteBuffer backed by lazy with nullable var + try-catch - Replace YuvImage.compressToJpeg() (causes libhwui.so MTE crash) with manual NV21→ARGB8888 pixel conversion. - Add empty-buffer guards in detectFaces and nv21toBitmap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue described in #3522 at least on my devices. Please note, that this fix has been entirely generated with a LLM. Since I am neither familiar with Android development in general or microg in particular nor very good with Java, I can't really review the changes properly. However, it does fix the issue on my 2 test devices, so I want to provide at least the code here ...