Fix joint rpca handling#831
Open
sabujcb wants to merge 6 commits into
Open
Conversation
Author
TuomasBorman
requested changes
Jun 12, 2026
TuomasBorman
left a comment
Contributor
There was a problem hiding this comment.
Thanks! See comments.
Member
|
Hi @sabujcb - add justifications where you can and where not sure you can flag those for discussion. |
sabujcb
commented
Jun 15, 2026
sabujcb
left a comment
Author
There was a problem hiding this comment.
I checked everything, and all changes were taken into account.
antagomir
approved these changes
Jun 15, 2026
Member
|
Checks are still failing with this: `> mae[[2]] <- transformAssay(
Error: object 'FALS' not found -> did you try & run these with the code before PR: |
Author
I executed PR from RStudio terminal and not exactly using these commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.