Skip to content

Fix joint rpca handling#831

Open
sabujcb wants to merge 6 commits into
microbiome:develfrom
sabujcb:fix-joint-rpca-handling
Open

Fix joint rpca handling#831
sabujcb wants to merge 6 commits into
microbiome:develfrom
sabujcb:fix-joint-rpca-handling

Conversation

@sabujcb

@sabujcb sabujcb commented Jun 10, 2026

Copy link
Copy Markdown

No description provided.

@sabujcb

sabujcb commented Jun 11, 2026

Copy link
Copy Markdown
Author

#831 @antagomir

@TuomasBorman TuomasBorman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See comments.

Comment thread .github/workflows/r.yml Outdated
Comment thread R/getRPCA.R Outdated
Comment thread R/getRPCA.R Outdated
Comment thread R/getRPCA.R Outdated
Comment thread R/getRPCA.R Outdated
Comment thread R/transformCounts.R Outdated
@antagomir

Copy link
Copy Markdown
Member

Hi @sabujcb - add justifications where you can and where not sure you can flag those for discussion.

@sabujcb sabujcb left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked everything, and all changes were taken into account.

@antagomir

Copy link
Copy Markdown
Member

Checks are still failing with this:

`> mae[[2]] <- transformAssay(

  • mae[[2]], assay.type = "mtx", method = "rclr", impute = FALS)
    

Error: object 'FALS' not found
Execution halted
`

-> did you try & run these with the code before PR:

R CMD build mia 
R CMD check mia_a.b.c.tar.gz
R CMD BiocCheck mia_a.b.c.tar.gz
R CMD INSTALL mia_a.b.c.tar.gz 

@sabujcb

sabujcb commented Jun 15, 2026

Copy link
Copy Markdown
Author

Checks are still failing with this:

`> mae[[2]] <- transformAssay(

  • mae[[2]], assay.type = "mtx", method = "rclr", impute = FALS)
    

Error: object 'FALS' not found Execution halted `

-> did you try & run these with the code before PR:

R CMD build mia 
R CMD check mia_a.b.c.tar.gz
R CMD BiocCheck mia_a.b.c.tar.gz
R CMD INSTALL mia_a.b.c.tar.gz 

I executed PR from RStudio terminal and not exactly using these commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants