Skip to content

Rework authentication UI + OAuth support#90

Merged
devnied merged 28 commits into
masterfrom
feature/rework-authentication
Feb 13, 2025
Merged

Rework authentication UI + OAuth support#90
devnied merged 28 commits into
masterfrom
feature/rework-authentication

Conversation

@devnied

@devnied devnied commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

Rework the current authentication UI and add Oauth support.

  • Add tooltip for all settings
  • Rewrite the datasource configuration UI
  • Support non encoded private key in the datasource configuration.
  • Add Oauth settings

Closes #47

Add tooltip for all settings
Rewrite the datasource configuration UI
Support non encoded private key in the datasource configuration.
@devnied devnied added the enhancement New feature or request label Oct 6, 2024
@devnied devnied added this to the 1.8.0 milestone Oct 6, 2024
@devnied devnied modified the milestones: 1.8.0, 1.9.0 Oct 17, 2024
Add tooltip for all settings
Rewrite the datasource configuration UI
Support non encoded private key in the datasource configuration.
@devnied devnied force-pushed the feature/rework-authentication branch from 7ce34b9 to be17ada Compare November 4, 2024 22:10
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2024

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
25.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@devnied devnied marked this pull request as draft December 4, 2024 16:04
@rumbin

rumbin commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Just a heads-up:
If the OAuth support is intended to support user umpersonation, this may conflict with connection pooling #91.

@devnied

devnied commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator Author

That’s a good point. However, for now, OAuth support will be limited to a single ‘Application Account’ that will handle all queries.

devnied and others added 7 commits January 14, 2025 19:02
Signed-off-by: devnied <mxjulien@gmail.com>
Signed-off-by: devnied <mxjulien@gmail.com>
Signed-off-by: Julien Millau <mxjulien@gmail.com>
Signed-off-by: Julien Millau <mxjulien@gmail.com>
Signed-off-by: Julien Millau <mxjulien@gmail.com>
devnied and others added 5 commits January 22, 2025 09:17
Signed-off-by: Julien Millau <mxjulien@gmail.com>
Signed-off-by: devnied <mxjulien@gmail.com>
Signed-off-by: devnied <mxjulien@gmail.com>
Signed-off-by: devnied <mxjulien@gmail.com>
Signed-off-by: Julien Millau <995890+devnied@users.noreply.github.com>
@devnied devnied marked this pull request as ready for review February 12, 2025 10:39
Signed-off-by: Julien Millau <julien.millau@michelin.com>
Signed-off-by: Julien Millau <julien.millau@michelin.com>
Signed-off-by: Julien Millau <julien.millau@michelin.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@devnied devnied merged commit 3fb89b8 into master Feb 13, 2025
@devnied devnied deleted the feature/rework-authentication branch February 13, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request for Oauth connection in this plugin

2 participants