Drop Kafka Connect health check and draft detection#753
Open
loicgreffier wants to merge 10 commits into
Open
Conversation
loicgreffier
force-pushed
the
no-health-check
branch
from
d1b2322 to
9125326
Compare
loicgreffier
changed the title
loicgreffier
force-pushed
the
no-health-check
branch
3 times, most recently
from
af633f1 to
ccbd877
Compare
|
loicgreffier
force-pushed
the
no-health-check
branch
from
c0ce3fd to
17677c1
Compare
loicgreffier
force-pushed
the
no-health-check
branch
from
53916b7 to
8698122
Compare
loicgreffier
force-pushed
the
no-health-check
branch
3 times, most recently
from
4202015 to
65524e6
Compare
loicgreffier
force-pushed
the
no-health-check
branch
2 times, most recently
from
f28452b to
651df8d
Compare
# Conflicts: # src/main/java/com/michelin/ns4kafka/service/ConnectorService.java # src/main/java/com/michelin/ns4kafka/service/executor/ConnectorAsyncExecutor.java # Conflicts: # src/test/java/com/michelin/ns4kafka/service/ConnectorServiceTest.java
loicgreffier
force-pushed
the
no-health-check
branch
from
88c13e8 to
2091164
Compare
|
Comment on lines
+145
to
+146
| connector.getMetadata().setStatus(Resource.Metadata.Status.ofFailed(httpError.getMessage())); | ||
| connectorRepository.create(connector); |
Collaborator
There was a problem hiding this comment.
How about marking the connect cluster as failed as well if it has "deleting" status?
When trying to cascade delete connect cluster and a connector deletion fails, the connect cluster stays with "deleting" status even if the cascade deletion failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listendpoint is returning the Kafka Connect status. The deprecatedgetendpoint won't do it anymore.version(String kafkaCluster, String connectCluster)function which iterate over all Kafka Connects has been removed: https://github.com/michelin/ns4kafka/blob/master/src/main/java/com/michelin/ns4kafka/service/client/connect/KafkaConnectClient.java#L108. The decrypted configuration can be computed upstream.