Fix handle_hls_stream_proxy not honoring TRANSPORT_ROUTES configuration#278
Conversation
WalkthroughThe HLS stream proxy handler now passes the HLS destination parameter when creating the streamer instance. The ChangesHLS Streamer Initialization
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
handle_hls_stream_proxywas callingcreate_streamer()with no URL, so the session was built against no route match.With
PROXY_ALL=truethis worked incidentally because the default proxy applied to all sessions regardless of URL.With TRANSPORT_ROUTES-only configuration, the no-URL call returned the default (no proxy), so the manifest request to matched domains bypassed the proxy entirely.
Passing
hls_params.destinationgives the routing config the URL it needs to match against configured patterns and build the session with the correct connector (e.g. SOCKS5 ProxyConnector).Summary by CodeRabbit