fix eth_getLogs panic when block hash lookup returns no block#655
Open
mooncitydev wants to merge 1 commit into
Open
fix eth_getLogs panic when block hash lookup returns no block#655mooncitydev wants to merge 1 commit into
mooncitydev wants to merge 1 commit into
Conversation
TendermintBlockByHash can return (nil, nil) without error when the block is missing from the local store. Avoid dereferencing resBlock before use. Closes the crash reported in mezo-org#595. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
TendermintBlockByHash can return (nil, nil) when the block is not in the local store (see
pc/backend/blocks.go). \Filter.Logs\ only checked the error value and then used
esBlock.Block.Height, which caused the nil pointer panic reported in #595.
This adds a nil guard and a regression test that reproduces the backend behavior.
testing
made by mooncitydev