Skip to content

Document MySQL branch copy behaviour and TLS steal scoping - #372

Open
skreborn wants to merge 1 commit into
mainfrom
skreborn/mysql-branch-parity
Open

skreborn wants to merge 1 commit into
mainfrom
skreborn/mysql-branch-parity

Conversation

@skreborn

Copy link
Copy Markdown
Contributor

Resolves INT-747.

Documents what a MySQL or MariaDB branch copy carries and the server settings it mirrors, the grant needed to copy routines defined by other accounts, the new serverName field on TLS steal configs, and that a steal config without targetPath or selector applies to every target in its namespace.

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

INT-747

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Retrigger

The PR appears safe to merge, with a non-blocking documentation gap around the minimum versions required for serverName.

Fix All in CursorFindings

  1. P2 Minimum versions remain unspecified
Fix with agent prompt
### Issue 1
docs/using-mirrord/incoming-traffic/steal-https.md:26
The compatibility note introduces the version-gated `serverName` field without naming the minimum operator and agent versions that support it. Directing users to an unidentified release's changelogs prevents them from determining whether their installation accepts the example configuration.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary

This PR documents MySQL and MariaDB branch-copy behavior and adds guidance for scoping TLS steal resources and configuring TLS server-name verification.

  • Explains which database objects and server settings branch copies preserve.
  • Documents privileges needed to copy routines owned by other database accounts.
  • Warns about unscoped TLS steal configurations and adds agentAsClient.verification.serverName.
  • The new version-gated TLS field lacks concrete minimum supported versions.

Reviews (1) · Last reviewed commit: "Document MySQL branch copy behaviour and..."

Comment thread docs/using-mirrord/incoming-traffic/steal-https.md Outdated
@skreborn
skreborn requested a review from liron-sel September 17, 2026 11:22
@skreborn
skreborn added this pull request to stack #374 September 17, 2026 15:17
@skreborn
skreborn force-pushed the skreborn/mysql-branch-parity branch from ea739f8 to 2b4527e Compare September 18, 2026 10:13
@skreborn
skreborn requested a review from giIuis September 18, 2026 14:01
@skreborn
skreborn force-pushed the skreborn/mysql-branch-parity branch from 2b4527e to 83ef4a5 Compare September 22, 2026 10:29
@skreborn
skreborn removed this pull request from stack #374 September 22, 2026 10:29
@skreborn
skreborn force-pushed the skreborn/mysql-branch-parity branch from 83ef4a5 to 28a4b38 Compare September 22, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants