Skip to content

INT-711 Queue splitting - NATS Pub Sub support - #358

Merged
vladrbg merged 6 commits into
mainfrom
vladr/nats-pubsub
Sep 23, 2026
Merged

vladrbg merged 6 commits into
mainfrom
vladr/nats-pubsub

Conversation

@vladrbg

@vladrbg vladrbg commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vladrbg
vladrbg requested a review from skreborn September 3, 2026 08:40
@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR expands the queue-splitting documentation from NATS JetStream to include Core NATS Pub/Sub.

  • Adds Core NATS routing, configuration, filtering, and best-effort delivery guidance.
  • Adds NATS Pub/Sub to the feature matrix and shared queue-filter reference.
  • Renames the navigation entry from “NATS JetStream” to “NATS.”

Important Files Changed

Filename Overview
docs/sharing-the-cluster/queue-splitting/nats.md Adds Core NATS Pub/Sub setup and routing guidance, but omits minimum compatible Operator and CLI versions.
docs/sharing-the-cluster/queue-splitting.md Extends the shared queue type, message-filter, jq-filter, and session-key documentation for NATS Pub/Sub.
docs/reference/feature-matrix.md Adds an Alpha support row for Core NATS Pub/Sub.
docs/SUMMARY.md Broadens the existing navigation label from NATS JetStream to NATS.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  P[Original NATS subject] --> O[mirrord Operator]
  O -->|filter matches| S[Session-prefixed subject]
  O -->|no filter matches| W[Workload fallback subject]
  S --> L[Local application]
  W --> D[Deployed workload]
Loading

Fix all with Greploop Fix All in Cursor Fix All in Codex Fix All in Claude Code

Prompt To Fix All With AI
### Issue 1
docs/sharing-the-cluster/queue-splitting/nats.md:311
**Missing compatibility version requirements**

The new `operator.natsPubsubSplitting`, `kind: natsPubSub`, and `queue_type: NATSPubSub` identifiers are documented without the minimum compatible Operator and CLI versions. Users with older installations cannot determine compatibility from this guide and can encounter an ignored Helm value or an unrecognized configuration variant.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix" | Re-trigger Greptile

Comment thread docs/sharing-the-cluster/queue-splitting/nats.md Outdated

@skreborn skreborn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queueType list in status.md doesn't include NATSPubSub. NATS and BullMQ appear to be missing, as well. In the same file, the resolved-name list doesn't contain subject.

Comment thread docs/sharing-the-cluster/queue-splitting/nats.md Outdated
@skreborn

skreborn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Note that this isn't properly linked to INT-711.

vladrbg and others added 2 commits September 10, 2026 11:15
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@vladrbg vladrbg changed the title Queue splitting - NATS Pub Sub support INT-711 Queue splitting - NATS Pub Sub support Sep 10, 2026
@linear-code

linear-code Bot commented Sep 10, 2026

Copy link
Copy Markdown

INT-711

Co-authored-by: Cursor <cursoragent@cursor.com>
@vladrbg
vladrbg requested a review from skreborn September 10, 2026 07:04
Comment thread docs/sharing-the-cluster/queue-splitting/nats.md Outdated
Comment thread docs/sharing-the-cluster/queue-splitting/nats.md Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>
@vladrbg
vladrbg requested a review from skreborn September 23, 2026 10:41
@vladrbg
vladrbg merged commit ef903cb into main Sep 23, 2026
3 checks passed
@vladrbg
vladrbg deleted the vladr/nats-pubsub branch September 23, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants