98 utilize streams#101
Draft
ostempel wants to merge 5 commits into
Draft
Conversation
Open
ostempel
force-pushed
the
98-utilize-streams
branch
2 times, most recently
from
bc226ba to
e9ccaac
Compare
ostempel
force-pushed
the
98-utilize-streams
branch
from
e9ccaac to
e68bf66
Compare
ostempel
force-pushed
the
98-utilize-streams
branch
from
adc8066 to
318d592
Compare
Gerrit91
added
area: control-plane
Contributor
|
First off, thanks @ostempel for this PR. I really like the general idea of it. At the same time, the changes introduce a significant amount of complexity, which makes it quite hard to review. We should discuss if we want to have this and if it's worth to add this complexity. |
|
postponed due to its high complexity and more important topics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #98
Switch from paths & file-handling to streams. In order to accomplish this I've added the new
archivespackage (archiverdeprecated ->archivesnew package with better support for streams)