Conversation
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
===========================================
- Coverage 92.15% 50.78% -41.37%
===========================================
Files 58 58
Lines 4408 4405 -3
===========================================
- Hits 4062 2237 -1825
- Misses 346 2168 +1822
... and 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Paused this for now and we need to verify with TorchRec on its usage. |
|
Hi @fduwjj! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
As part of ShardedTensor deprecation, we start the cleanup for its use case in torch snapshot. This is the first PR for a series PR and want to get feedback from owner and the community to see if this is the right thing to do.
Summary:
As above.
Test plan:
Unit test.