Skip to content

Remove ST from torchsnapshot#143

Open
fduwjj wants to merge 1 commit into
mainfrom
st_remove
Open

Remove ST from torchsnapshot#143
fduwjj wants to merge 1 commit into
mainfrom
st_remove

Conversation

@fduwjj

@fduwjj fduwjj commented May 22, 2023

Copy link
Copy Markdown

As part of ShardedTensor deprecation, we start the cleanup for its use case in torch snapshot. This is the first PR for a series PR and want to get feedback from owner and the community to see if this is the right thing to do.

Summary:
As above.

Test plan:
Unit test.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2023
@fduwjj fduwjj requested a review from yifuwang May 22, 2023 23:29
@codecov

codecov Bot commented May 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #143 (496be7c) into main (087caae) will decrease coverage by 41.37%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #143       +/-   ##
===========================================
- Coverage   92.15%   50.78%   -41.37%     
===========================================
  Files          58       58               
  Lines        4408     4405        -3     
===========================================
- Hits         4062     2237     -1825     
- Misses        346     2168     +1822     
Impacted Files Coverage Δ
torchsnapshot/io_preparer.py 67.21% <100.00%> (-29.62%) ⬇️

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fduwjj

fduwjj commented Jun 1, 2023

Copy link
Copy Markdown
Author

Paused this for now and we need to verify with TorchRec on its usage.

@meta-cla

meta-cla Bot commented May 23, 2026

Copy link
Copy Markdown

Hi @fduwjj!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants