defensive snapshot of model_out via torch._foreach_clone#4341
Open
jeffkbkim wants to merge 1 commit into
Open
Conversation
Summary: Take a defensive batched clone of `model_out` (and any tensor kwargs) in `_update_rec_metrics` before enqueueing a `MetricUpdateJob`, so the worker thread always observes a stable snapshot regardless of what the caller does with its references after `update()` returns. Differential Revision: D107427093
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@jeffkbkim has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107427093. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Take a defensive batched clone of
model_out(and any tensor kwargs) in_update_rec_metricsbefore enqueueing aMetricUpdateJob, so the worker thread always observes a stable snapshot regardless of what the caller does with its references afterupdate()returns.Differential Revision: D107427093