Add a targeted HFTokenizer encode-latency benchmark#194
Open
digantdesai wants to merge 1 commit into
Open
Conversation
This was referenced Jun 12, 2026
mergennachin
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Standalone Release-optimized benchmark for the HFTokenizer long-prompt encode
path. It repeats prose/code/dialogue templates to long inputs (~0.5k-8k tokens)
and prints mean encode latency. This is a targeted latency benchmark for this
code path, not a generic tokenizer harness; correctness is covered by the unit
tests and it exits nonzero if any encode errors.
Baseline latency on the original (pre-fix) code, Gemma-4-31B tokenizer, Release,
mean of 5 reps:
Latency grows with the square of input length (chars x5.5 from prose_2k to
prose_8k -> time x31.6 ~= 5.5^2); an 8k-token prompt takes ~123 s. Gemma's
normalizer turns spaces into the word marker before the space-splitter runs, so
the whole prompt is BPE-merged as a single piece.
Authored with assistance from Claude Code.