Various small improvements#9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes incremental improvements to the Gaussian splatting training workflow, including logging updates, new training configuration options, checkpoint resume enhancements, and support for excluding selected SfM views.
Changes:
- Adds trainer options for masked views, progress-bar usage, scheduler usage, and optimizer-state restoration.
- Moves checkpoint loading into the training loop and stores optimizer/strategy state in checkpoints.
- Replaces several
printcalls with logging and updates Meshroom node parameters to expose new options.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
meshroom/mrGSplat/GaussianSplattingOptim.py |
Exposes new Meshroom controls for masked views, progress bars, and optimizer-state resume behavior. |
gsplatInterface/viewer.py |
Allows loading richer checkpoints by registering NumPy safe globals. |
gsplatInterface/trainer.py |
Adds new config fields, logging setup, resume-state handling, scheduler changes, and training-loop updates. |
gsplatInterface/datasets/sfm/sceneManager.py |
Adds masked-view filtering and converts parser status output to logging. |
gsplatInterface/datasets/sfm/interface.py |
Converts SfM file read status output to logging. |
gsplatInterface/common.py |
Adds optional progress-bar suppression support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4ee971b to
f529cec
Compare
9d0b3d3 to
51d0b1b
Compare
…imilar effects for the default strategy and MCMC
51d0b1b to
1363be2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the
gsplatInterfacecodebase, focusing on enhanced logging, improved configurability, better training control, and expanded dataset handling. The main changes include switching from print statements to Python's logging module, adding configuration options for masking views and progress bar usage, updating learning rate handling, and refining the training loop for checkpointing and memory management.Logging and Configuration Improvements:
printstatements withloggingfor more flexible and standardized output, and set up a customizable logging format intrainer.pyand related modules. [1] [2] [3] [4] [5] [6] [7]Configdataclass:mask_viewsfor excluding specific views from training,use_progress_barfor toggling progress bar display,retrieve_optimizer_statefor controlling checkpoint loading, anduse_schedulerfor learning rate scheduling. [1] [2] [3]Training Loop and Checkpoint Handling:
torch.cuda.empty_cache(). [1] [2] [3] [4]Progress Bar and Masked Views Support:
ProgressBarutility to allow toggling progress bar usage and improved its integration with training. [1] [2]Learning Rate Handling:
meansparameter depending on the optimization strategy, and added factors for other parameters for better control and consistency. [1] [2] [3]Miscellaneous:
These changes collectively improve the usability, flexibility, and robustness of the training pipeline and associated utilities.