Create consumer-smoke.sh#994
Closed
raymondoyondi wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Raymond Oyondi <raymondoyondi@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new smoke test script, consumer-smoke.sh, designed to verify that MeshKit can be correctly used as a dependency in external Go modules. The feedback suggests improving the script's portability by using $PWD as a fallback for the workspace path and recommends running go mod tidy to ensure the temporary module's dependencies are correctly resolved before execution.
Signed-off-by: Raymond Oyondi <raymondoyondi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a consumer-oriented smoke script that creates a temporary external Go module, pins MeshKit via replace, and runs tests to confirm MeshKit can still be consumed as a downstream dependency after dependency updates.
Signed-off-by: raymondoyondi raymondoyondi@gmail.com
Closes #434