feat: Add aws_identity_store support to meshstack_platform AWS replication config#125
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add awsIdentityStore support to meshstack_meshplatform resource
feat: Add aws_identity_store support to meshstack_platform AWS replication config
Mar 11, 2026
grubmeshi
reviewed
Mar 11, 2026
Member
|
@grubmeshi a general question why do we have examples as tf code files and then there's also Is there some way to verify/validate the examples that go into md files, or maybe even source them from a proper tf file? I'm sure other TF providers must have solved that same problem already. |
grubmeshi
reviewed
Mar 12, 2026
grubmeshi
requested changes
Mar 12, 2026
Co-authored-by: JohannesRudolph <130103+JohannesRudolph@users.noreply.github.com>
… separate 09 example Co-authored-by: grubmeshi <247164247+grubmeshi@users.noreply.github.com>
meshStack does not enforce such a prefix, a parallel fix will be made to meshStack docs upstream
ff0799f to
b5a9c6d
Compare
a5f1e95 to
5927632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
aws_identity_storeas an optional replication block for AWS platforms, using the AWS Identity Store API directly instead of SCIM. Unlikeaws_sso, it requires no SCIM token and is compatible with Workload Identity Federation.Changes
client/platform_config_aws.go: NewAwsIdentityStoreConfig,AwsIdentityStoreRoleMapping, andAwsIdentityStoreProjectRoleRefstructs;AwsIdentityStorefield added toAwsReplicationConfigplatform_resource_schema_aws.go: Newaws_identity_storeblock withConflictsWithvalidators on bothaws_ssoandaws_identity_storeto enforce mutual exclusivityresource_02_aws.tf: Updated existing AWS example to showcaseaws_identity_storeinstead ofaws_ssoplatform_resource_test.go: UpdatedcheckAwsPlatformConfigto assertaws_identity_storefields andaws_sso: nullNotable design decision
Per explicit requirement,
project_role_refinaws_identity_store.aws_role_mappingsexposes onlyname—kindis omitted from the schema entirely (always implicitlymeshProjectRole), unlike theaws_ssopattern which uses a computedkindfield.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.