Refactor request pipeline#9
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors CLAI’s OpenAI request/response pipeline to keep message history and payloads as structured JSON (via jq), while hardening first-run config/state bootstrapping and adding Bats coverage for payload/error handling paths.
Changes:
- Replace hand-built JSON string assembly/parsing with
jq-constructed message history and request payloads. - Add explicit handling for curl transport failures, non-2xx HTTP responses, and non-JSON API responses.
- Extend Bats smoke tests and update README to reflect the new bootstrap/error-handling behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
clai.sh |
Converts history/payload pipeline to jq JSON, adds config directory bootstrap + permission hardening, and improves API error handling. |
test/smoke.bats |
Adds tests for JSON payload generation and HTTP error surfacing; refactors config setup helper. |
README.md |
Updates documentation to describe new bootstrap behavior, JSON payload construction, and error distinctions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #7
Fixes #5
Fixes #6