Refine history persistence architecture#16
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors CLAI’s cross-session history persistence to be more robust and intentional: atomic writes, explicit save points, warning on failures, and persisting a turn-trimmed conversation view rather than raw transcripts.
Changes:
- Add atomic history persistence (temp file + rename) with warnings on parse/write failures.
- Introduce
max_history_turns(with deprecatedmax_historyfallback) and trim persisted history by user-turn boundaries. - Extend Bats coverage for invalid history repair, turn-based trimming, deprecation behavior, and ensuring system messages aren’t persisted.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
clai.sh |
Implements atomic history writes, new max_history_turns config handling, history normalization/trimming, and explicit exit persistence. |
test/smoke.bats |
Updates configs to max_history_turns and adds tests for trimming behavior, legacy key warning, and invalid history handling. |
README.md |
Documents max_history_turns and deprecates max_history. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_history_turnswhile keeping legacymax_historyas a deprecated compatibility fallbackVerification
Fixes #12