Skip to content

feat: mutation viewer#174

Draft
j10a1n15 wants to merge 15 commits into
mainfrom
feat/mutation-viewer
Draft

feat: mutation viewer#174
j10a1n15 wants to merge 15 commits into
mainfrom
feat/mutation-viewer

Conversation

@j10a1n15

Copy link
Copy Markdown
Member

No description provided.

j10a1n15 and others added 11 commits December 17, 2025 21:15
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
# Conflicts:
#	src/main/kotlin/me/owdding/skyocean/utils/codecs/CodecHelpers.kt
@j10a1n15 j10a1n15 marked this pull request as draft December 23, 2025 21:07
@github-actions

Copy link
Copy Markdown

113 Detekt Failures

Rules flagged (18): ImportOrdering, DoubleNegativeLambda, MayBeConstant, StringTemplate, BlankLineBetweenWhenConditions, ValueParameterComment, NoUnusedImports, FunctionExpressionBody, UnusedParameter, EmptyFunctionBlock (+ 8 more)
Files flagged (21): SkyOcean.kt, SerializeMutation.kt, CraftHelperStorage.kt, ButtonConfigScreen.kt, ItemCustomizationModal.kt, ItemSelectorOverlay.kt, CompactLevelBarsModifier.kt, BlockRetexture.kt, FakeBlockModel.kt, FakeBlocks.kt (+ 11 more)

Rule violations
  • SkyOcean.kt#L3 ImportOrdering: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
  • SerializeMutation.kt#L39 DoubleNegativeLambda: Double negative through using != inside a takeUnless lambda. Use takeIf instead.
  • SerializeMutation.kt#L32 MayBeConstant: paletteChars can be a const val.
  • SerializeMutation.kt#L48 StringTemplate: Redundant curly braces
  • CraftHelperStorage.kt#L34 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
  • ButtonConfigScreen.kt#L54 ValueParameterComment: A comment inside or on same line after a 'value_parameter' is not allowed. It may be placed on a separate line above.
  • ItemCustomizationModal.kt#L63 NoUnusedImports: Unused import
  • ItemSelectorOverlay.kt#L21 NoUnusedImports: Unused import
  • CompactLevelBarsModifier.kt#L27 FunctionExpressionBody: Function body should be replaced with body expression
  • BlockRetexture.kt#L28 UnusedParameter: Function parameter parent is unused.
  • FakeBlockModel.kt#L36 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
  • FakeBlockModel.kt#L37 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
  • FakeBlockModel.kt#L37 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
  • FakeBlockModel.kt#L39 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
  • FakeBlocks.kt#L3 ImportOrdering: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end -- no autocorrection due to comments in the import list
  • PlayerHeadModel.kt#L44 EmptyFunctionBlock: This empty block of code can be removed.
  • PlayerHeadModel.kt#L24 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L23 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L24 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L23 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L24 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L23 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L24 ClassOrdering: companion object should be declared after method declarations.
  • PlayerHeadModel.kt#L23 ClassOrdering: companion object should be declared after method declarations.
  • SkyOceanModel.kt#L120 EmptyFunctionBlock: This empty block of code can be removed.
  • SkyOceanModel.kt#L80 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L70 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L80 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L70 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L80 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L70 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L80 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L70 ClassOrdering: property transform should be declared before method declarations.
  • SkyOceanModel.kt#L55 TrailingCommaOnDeclarationSite: Missing trailing comma before ")"
  • MutationData.kt#L142 TrailingCommaOnDeclarationSite: Missing trailing comma before ";"
  • Utils.kt#L3 ImportOrdering: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
  • Utils.kt#L54 NoUnusedImports: Unused import
  • CodecHelpers.kt#L98 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L98 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L98 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L98 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L100 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L100 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L100 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L100 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L87 ClassOrdering: method unit() should be declared after property declarations and initializer blocks.
  • CodecHelpers.kt#L176 Indentation: Unexpected indentation (20) (should be 16)
  • GuiBlockRenderer.kt#L73 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L72 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L73 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L72 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L73 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L72 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L73 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • GuiBlockRenderer.kt#L72 ClassOrdering: method getFactory() should be declared after property declarations and initializer blocks.
  • InventoryRenderer.kt#L106 NoTrailingSpaces: Trailing space(s)
  • InventoryRenderer.kt#L138 NoTrailingSpaces: Trailing space(s)
  • InventoryRenderer.kt#L6 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L8 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L9 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L10 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L11 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L12 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L13 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L14 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L16 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L24 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L25 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L26 NoUnusedImports: Unused import
  • InventoryRenderer.kt#L27 NoUnusedImports: Unused import
  • Pip.kt#L4 NoUnusedImports: Unused import
  • RenderUtils.kt#L36 FunctionNaming: Function names should match the pattern: (?:[a-z]+$[a-z][a-zA-Z0-9])|(?:[a-z][a-zA-Z0-9])
  • RenderUtils.kt#L38 FunctionNaming: Function names should match the pattern: (?:[a-z]+$[a-z][a-zA-Z0-9])|(?:[a-z][a-zA-Z0-9])
  • RenderUtils.kt#L204 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L204 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L204 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L204 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_BACK_SPRITE should be declared before method declarations.
  • RenderUtils.kt#L205 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L205 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L205 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L205 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L143 ClassOrdering: property SLOT_HIGHLIGHT_FRONT_TEXTURE should be declared before method declarations.
  • RenderUtils.kt#L70 DestructuringDeclarationWithTooManyEntries: The destructuring declaration contains 6 but only 5 are allowed.
  • RenderUtils.kt#L228 DestructuringDeclarationWithTooManyEntries: The destructuring declaration contains 6 but only 5 are allowed.
  • RenderUtils.kt#L154 NoBlankLineInList: Unexpected blank line(s) in value argument list
  • RenderUtils.kt#L3 NoUnusedImports: Unused import
  • RenderUtils.kt#L6 NoUnusedImports: Unused import
  • RenderUtils.kt#L135 TrailingCommaOnCallSite: Missing trailing comma before ")"
  • StyledItemWidget.kt#L3 ImportOrdering: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end -- no autocorrection due to comments in the import list
  • StyledItemWidget.kt#L241 NoBlankLineInList: Unexpected blank line(s) in value parameter list
  • StyledItemWidget.kt#L241 NoTrailingSpaces: Trailing space(s)
  • SkyblockTagKey.kt#L41 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L20 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L41 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L20 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L41 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L20 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L41 ClassOrdering: property location should be declared before method declarations.
  • SkyblockTagKey.kt#L20 ClassOrdering: property location should be declared before method declarations.

@github-actions

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before the pull request can be reviewed.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before the pull request can be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants