Fix: attempts to optimize wardrobe#107
Open
ninjaguardian wants to merge 4 commits into
Open
Conversation
ninjaguardian
changed the title
Member
|
This doesnt seem to do anything besides moving around functions, the problem is just that rendering players is an expensive operation in a gui, and needs to be done all in 1 call rather than x number of renders. |
|
This pull request has conflicts, please resolve those before the pull request can be reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to optimize the wardrobe
(Related to #106, but not a full resolution)
This pr is mainly a bunch of caching.
The main issue is definitely
Displays.entity()being called with all the rotation, which still tanks fps.