Skip to content

Keep real browser startup timeout and cleanup inside Playwright - #64

Draft
Fectivnfy112357 wants to merge 1 commit into
mainfrom
fix/edge-fixture-launch-timeout
Draft

Fectivnfy112357 wants to merge 1 commit into
mainfrom
fix/edge-fixture-launch-timeout

Conversation

@Fectivnfy112357

Copy link
Copy Markdown
Contributor

What changes

  • Pass the existing 120-second startup bound into Playwright so that Playwright aborts and cleans up its own launch, and preserves its browser startup log. The outer promise race previously returned without asking Playwright to cancel the launch.
  • Clean up the fixture's dedicated profile and any context it acquired if launch or service-worker initialization fails. The positive and refused-key acceptance assertions and launch budget are unchanged.

Evidence

Main CI run 209's Ubuntu browser shard timed out before Edge returned a browser context; later Edge cases in the same shard passed. The existing failure trace does not reveal the underlying startup cause. This change fixes fixture ownership and exposes native launch details; it does not claim to fix Edge startup itself.

WebUI test typecheck and diff check passed. A controlled Playwright launch using an inert test process confirmed timeout diagnostics and process/profile cleanup; an injected service-worker initialization failure confirmed context/profile cleanup. Real Edge acceptance could not reach the handshake on the local executor because Edge's startup was denied socket/ptrace operations. Hosted CI still needs to verify both Edge handshake cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant