Repository navigation
Fix browser frame handoff and isolate first-frame CI evidence - #62
Merged
Merged
Conversation
Fectivnfy112357
marked this pull request as ready for review
November 20, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed: a replacement browser watcher can lose its frames
The last watcher used to await the provider stop before removing its subscriber and handler entries. A replacement could join or start in that gap, after which the old cleanup deleted the replacement's state. The test parks the fake provider's stop, starts a replacement, releases the stop, and delivers a distinct frame. On the unchanged runtime the replacement did not receive it.
Detach the old entries synchronously, then order the new start after the same provider/target stop. Canceled replacements can leave the wait immediately. Stale callbacks and finalizers must still own the exact subscription entry and provider. No timeout changes, skipped tests, new cache, or changes to explicit page close semantics.
Separately: first-frame CI evidence
Main run 207 macOS timed out waiting for a first frame after tab metadata arrived. We have not established that it hit the subscriber race. A separate test-only commit captures bounded operation timing and frame counts on failure, and namespaces the transcript's existing CDP artifacts so other suites cannot replace them. A local synthetic dropped-inbound-frame control failed the unchanged assertion and the evidence distinguished the received wire frame from the absent panel frame.
Verification