Repository navigation
Trace native acceptance runtime shutdown phases - #57
Open
Fectivnfy112357 wants to merge 1 commit into
Open
Fectivnfy112357 wants to merge 1 commit into
Fectivnfy112357 wants to merge 1 commit into
Conversation
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Related to #30. The original Windows run stopped in the harness shutdown after the sandbox reported
closed. The acceptance fixture supplied no browser provider and used a no-op mcode-tools disposer. The remaining waits in the shared runtime were indistinguishable from that log.Change
The native-browser acceptance child opts into fixed phase markers on stderr before the runtime awaits a shutdown owner. The markers identify the sandbox call, background maintenance, owner-lease release, legacy host close and database close. The existing acceptance host deadline continues to report a failed shutdown with captured stderr. Shutdown order and error propagation are retained. The source inventory and AOCI entries include the diagnostic helper.
Verification
This branch is based on #54, which passed the same WebUI CI matrix on Ubuntu, Windows and macOS. Review this PR against the #54 branch.
pnpm verifypassed all 26 applicable gates, including 515 browser cases.closed:falseandstalledAt:harnessafter 20,001 ms and exited. Captured stderr ended its runtime markers atrelease_runtime_owner. This validates the diagnostics on the timeout path. It does not identify the owner in the original Windows incident.Hosted WebUI CI run 44679668737 passed on Ubuntu, macOS, and Windows at
34b66747b. The Windows native terminal acceptance passed along with all 515 browser cases. The original shutdown timeout did not recur in this run.