Skip to content

fix(i18n): restore client workspace storage contract, reactive error banners, and demo gif - #55

Merged
mcocdaa merged 1 commit into
mainfrom
fix/round4-i18n-and-workspace-contract
Oct 17, 2026
Merged

mcocdaa merged 1 commit into
mainfrom
fix/round4-i18n-and-workspace-contract

Conversation

@mcocdaa

@mcocdaa mcocdaa commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Fixes Round-4 audit findings and CI client workspace contract:

  • Remove direct localStorage usage from packages/client-core/src/http/apiError.ts and packages/client-ui/src/i18n/index.ts, routing locale persistence through configureLocalePreferences in apps/clients/web/src/adapters/browserThemePreferences.ts and syncing setApiErrorLocale.
  • Re-translate active error banners reactively when toggling locale across views and composables.
  • Localize agent.chat.bindingLabel in AgentChatSession.vue and AgentPreviewView.vue, and translate agent.preview.mobileKeybarHeading in zh.
  • Re-record docs/assets/demo_termflow.gif (960x600, 49 frames, 27.93s duration, 1640ms keyframe holds).

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 46a69c85-4cb6-4ecf-8c22-48b6132ee5fb
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mcocdaa
mcocdaa merged commit f61f860 into main Oct 17, 2026
2 of 10 checks passed
@mcocdaa
mcocdaa deleted the fix/round4-i18n-and-workspace-contract branch October 17, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant