Rework mc-rtc-superbuild devshell#44
Open
arntanguy wants to merge 21 commits into
Open
Conversation
This enables overriding controllers/robots/plugins/observers from local builds
TODO: make mc-rtc-superbuild option into a function taking pkgs instead of doing it for each controller/plugin/observer/...
c2e57bc to
f0572f8
Compare
6956eaf to
67ab4e1
Compare
e28ffed to
c9418e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is attempting to simplify how devShells for
mc-rtc-superbuildenvironments are built. In particular, the goal is to support:inputsFromrequired to build the chosen controller/plugins/observers/robots/states/...mc_rtc.yamlto load themThe goal of 1. is local development, and 2. can be used to simply run the project from the binary cache.
In the spirit of
flakoboros, I am (slowly) converging towards a flake module with a configuration like (in a consumer's flake)where:
mc-rtc-superbuild.<attrName>as used for both devel and release shellsmc-rtc-superbuild.devel.<attrName>are used asinputFromin the devel shell, and merged with attributes inmc-rtc-superbuild.<attrName>for the release shell.As-is it works and generates
${pname}and${pname}-releasedevShells, but the implementation could be improved.TODO: