Skip to content

feat(WorldCup): Hide past matches and show teams for upcoming matches when known#3295

Merged
joshlarson merged 8 commits into
mainfrom
jdl/feat/hide-past-matches-and-show-teams
Jun 29, 2026
Merged

feat(WorldCup): Hide past matches and show teams for upcoming matches when known#3295
joshlarson merged 8 commits into
mainfrom
jdl/feat/hide-past-matches-and-show-teams

Conversation

@joshlarson

@joshlarson joshlarson commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Scope

No ticket; I just thought it would make the page easier to navigate if we didn't show past matches, and we already have the ability to show

Implementation

This may be easiest to review commit-by-commit. The non-refactor commits (1, 2, and 4) should be pretty easy to review on their own. I made the refactor commit because dealing with tuples more than 2-3 items long is a pain.

Screenshots

Screenshot 2026-06-29 at 10 34 04 AM

How to test

Check out the Boston Stadium Trains page!

If you want to pretend that it's a future date, update the definition of now to 👇

def now(), do: ~N[2026-06-30T03:00:00] |> Timex.to_datetime("America/New_York")

@joshlarson joshlarson marked this pull request as ready for review June 29, 2026 14:47
@joshlarson joshlarson requested a review from a team as a code owner June 29, 2026 14:47
@joshlarson joshlarson requested a review from jlucytan June 29, 2026 14:47
@joshlarson joshlarson merged commit eeb416e into main Jun 29, 2026
18 checks passed
@joshlarson joshlarson deleted the jdl/feat/hide-past-matches-and-show-teams branch June 29, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants