Skip to content

[ferry]: Update ferry fare cards#3294

Open
lvachon1 wants to merge 4 commits into
mainfrom
lev/feat/ferry/more_fare_card_stuff
Open

[ferry]: Update ferry fare cards#3294
lvachon1 wants to merge 4 commits into
mainfrom
lev/feat/ferry/more_fare_card_stuff

Conversation

@lvachon1

@lvachon1 lvachon1 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Scope

Asana Ticket: ⛴️ 💸 Update ferry fare cards

Implementation

  • Updated the reduced price fare
  • Added the new zone 1a fare card data
  • Cloned the ferry_inner_harbor fare entries into ferry_charlestown will remove the old entries once the content is updated.
  • Re-updated the reduced price fares, hopefully the right way this time

Screenshots

No visual changes?

How to test

http://localhost:4001/fares/ferry-fares

Not sure how to test, Confirm it doesn't crash?

@lvachon1 lvachon1 requested a review from a team as a code owner June 26, 2026 18:49
@lvachon1 lvachon1 requested a review from joshlarson June 26, 2026 18:49
@lvachon1 lvachon1 marked this pull request as draft June 26, 2026 20:15
…s computed in a function with route specific overrides?
@lvachon1 lvachon1 marked this pull request as ready for review June 29, 2026 13:21

@joshlarson joshlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing a bit more digging to see if I can help find more actionable feedback here, but this change is causing the ferry fares page to crash with 👇 stack trace:

2026-06-29 15:48:59.087 [error] mbta_id=43634282 request_id=GL2lFWcAPrnnmQcAAOli ** (BadMapError) expected a map, got:

    nil

    (dotcom 0.0.1) lib/dotcom_web/templates/cms/paragraph/_fare_card.html.heex:6: anonymous fn/2 in DotcomWeb.CMS.ParagraphView."_fare_card.html"/1
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:134: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.recur_iodata/1
    (dotcom 0.0.1) lib/dotcom_web/templates/cms/paragraph/_column_multi.html.heex:17: anonymous fn/2 in DotcomWeb.CMS.ParagraphView."_column_multi.html"/1
    (elixir 1.19.5) lib/enum.ex:1688: Enum."-map/2-lists^map/1-1-"/2
    (dotcom 0.0.1) lib/dotcom_web/templates/cms/paragraph/_column_multi.html.heex:16: anonymous fn/2 in DotcomWeb.CMS.ParagraphView."_column_multi.html"/1
    (elixir 1.19.5) lib/enum.ex:1688: Enum."-map/2-lists^map/1-1-"/2
    (elixir 1.19.5) lib/enum.ex:1688: Enum."-map/2-lists^map/1-1-"/2
    (dotcom 0.0.1) lib/dotcom_web/templates/cms/paragraph/_column_multi.html.heex:14: anonymous fn/3 in DotcomWeb.CMS.ParagraphView."_column_multi.html"/1
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:134: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.recur_iodata/1
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:146: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.recur_iodata/3
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:86: Phoenix.HTML.Safe.Phoenix.LiveView.Comprehension.to_iodata/2
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:82: anonymous fn/3 in Phoenix.HTML.Safe.Phoenix.LiveView.Comprehension.to_iodata/1
    (elixir 1.19.5) lib/enum.ex:2520: Enum."-reduce/3-lists^foldl/2-0-"/3
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:82: Phoenix.HTML.Safe.Phoenix.LiveView.Comprehension.to_iodata/1
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:146: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.recur_iodata/3
    (phoenix_html 4.3.0) lib/phoenix_html.ex:140: Phoenix.HTML.html_escape/1
    (phoenix_html_helpers 1.0.1) lib/phoenix_html_helpers/tag.ex:105: PhoenixHTMLHelpers.Tag.content_tag/3
    (dotcom 0.0.1) lib/dotcom_web/templates/layout/root.html.heex:137: anonymous fn/2 in DotcomWeb.LayoutView."root.html"/1
    (phoenix_live_view 1.1.26) lib/phoenix_live_view/engine.ex:134: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.recur_iodata/1
    (phoenix 1.8.6) lib/phoenix/controller.ex:1015: anonymous fn/5 in Phoenix.Controller.template_render_to_iodata/4

The crash is cache-dependent, so in order to reliably reproduce it, you need to run 👇 in an iEX shell while on your branch.

iex> Dotcom.Cache.Multilevel.flush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants