Skip to content

[feat] Stale old alerts on line diagram banner#3281

Draft
lvachon1 wants to merge 8 commits into
mainfrom
lev/feat/stale_alerts
Draft

[feat] Stale old alerts on line diagram banner#3281
lvachon1 wants to merge 8 commits into
mainfrom
lev/feat/stale_alerts

Conversation

@lvachon1

@lvachon1 lvachon1 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Scope

Asana Ticket: 🐬 Stale Symphony alert on line diagram banner on GL and GL-E pages

Implementation

  • Added logic to alerts.ex to identify and mark alerts as stale when the current active period has started more than five weeks ago
  • Added filter to remove stale alerts from the line diagram page.
  • Added tests

Interestingly the Symphony alert has been downgraded in priority and no longer shows on the line diagram anyway.

Screenshots

Dev-Blue

Screenshot 2026-06-29 at 3 13 26 PM

Local

Screenshot 2026-06-29 at 3 13 19 PM

How to test

http://localhost:4001/schedules/1/line

https://dev-blue.mbtace.com/schedules/1/line

On dev-green/blue, Bus 1 has a perpetual delay that started in May. Confirm it shows up on dev-blue/green, but not on this branch (when pointed at dev-blue/green)

@lvachon1 lvachon1 requested a review from a team as a code owner June 23, 2026 15:41
@lvachon1 lvachon1 requested a review from joshlarson June 23, 2026 15:41

@joshlarson joshlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - one is stylistic, the other is functional, but they're both blocking me from approving.

Also, I know the ticket mentions GL and GL-E, but this solution applies to any line diagram page (which I think is good), so I would also update the PR title (and thus the commit message when it gets merged) to not be GL/GL-E specific.

Comment thread lib/dotcom_web/templates/schedule/_line.html.heex Outdated
Comment thread lib/dotcom_web/templates/schedule/_line.html.heex Outdated
@lvachon1 lvachon1 changed the title [feat] Stale Symphony alert on line diagram banner on GL and GL-E pages [feat] Stale old alerts on line diagram banner Jun 26, 2026
@lvachon1 lvachon1 requested a review from joshlarson June 29, 2026 14:43
@lvachon1 lvachon1 marked this pull request as draft June 29, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants