refactor(utils): extract stripTrailingSlash and drop redundant require('path')#476
Merged
Merged
Conversation
…e('path')
- Add stripTrailingSlash() to utils as the single source of truth for the
`replace(/\/$/, '')` idiom; use it in the security path guards (2x) and the
Docker volume mount builder (2x).
- Remove two inline `require('path')` calls in docker-utils.ts in favor of the
existing top-level `import * as path from 'path'`.
Pure consolidation; behavior is unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure consolidation; behavior unchanged.
stripTrailingSlash()toutils.tsas the single source of truth for thereplace(/\/$/, '')idiom, used in the security path guards (2 sites) and the Docker volume mount builder (2 sites)require('path')calls indocker-utils.tsin favor of the existing top-levelimport * as path from 'path'Test
tsc --noEmitclean🤖 Generated with Claude Code