feat(api-keys): QR code on key creation encoding server URL + key (#1677)#1701
Open
bambuman wants to merge 1 commit into
Open
feat(api-keys): QR code on key creation encoding server URL + key (#1677)#1701bambuman wants to merge 1 commit into
bambuman wants to merge 1 commit into
Conversation
…ziggy#1677) Add a "QR code" button to the "API Key Created Successfully" panel that opens a modal with a single QR encoding the Bambuddy base URL and the new API key together, so a mobile client can scan once to configure both. Payload (v1 contract): bambuddy://config?v=1&url=<encodeURIComponent(baseUrl)>&key=<encodeURIComponent(apiKey)> - baseUrl prefers the configured External URL setting, falling back to window.location.origin. - The QR is generated client-side from the in-memory key (keys are stored hashed and never retrievable later), so it is never refetched. - Modal shows the QR, a caption, and a secret-key warning; closes on Escape. Adds the qrcode.react dependency (renders QRCodeSVG), a reusable buildApiKeyQrPayload() helper, and unit tests for the payload contract (scheme, v=1 first, URL-encoding, no raw-key leak, round-trip). New UI strings are added to all locale files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Sorry for the rule miss here — Claude had added a |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a QR code button to the "API Key Created Successfully" panel. Clicking it shows a modal with a single QR encoding the Bambuddy base URL and the new API key together, so a mobile client can scan once to configure both — no copy-pasting the long, shown-only-once key.
Related Issue
Fixes #1677
Documentation
Companion docs PRs:
Pick one:
Type of Change
Changes Made
ApiKeyQRCodeModal) on the key-creation success panel.bambuddy://config?v=1&url=<encodeURIComponent(baseUrl)>&key=<encodeURIComponent(apiKey)>, built by a reusablebuildApiKeyQrPayload()helper.baseUrlprefers the configured External URL setting, falling back towindow.location.origin(so the encoded address is reachable from a phone behind a reverse proxy / Docker host).qrcode.reactdependency; new UI strings added to all locale files.Screenshots
Testing
Unit tests for the payload contract (scheme,
v=1first, URL-encoding, no raw-key leak, query round-trip).tscclean,eslintclean, payload + i18n-parity suites pass (15 tests).Checklist