Skip to content

fix(ui): correct MCP tool execution timeout placeholder#5045

Open
Shaik-Sirajuddin wants to merge 1 commit into
maximhq:devfrom
Shaik-Sirajuddin:worktree-fix-mcp-exec-timeout-placeholder
Open

fix(ui): correct MCP tool execution timeout placeholder#5045
Shaik-Sirajuddin wants to merge 1 commit into
maximhq:devfrom
Shaik-Sirajuddin:worktree-fix-mcp-exec-timeout-placeholder

Conversation

@Shaik-Sirajuddin

@Shaik-Sirajuddin Shaik-Sirajuddin commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #5027

Summary

Small fix: the Tool Execution Timeout field placeholder in the MCP client edit sheet was hardcoded to 0 instead of showing the real global default (30), unlike the sibling Tool Sync Interval field which already reflects the fetched global value.

Changes

  • ui/app/workspace/mcp-registry/views/mcpClientSheet.tsx: added globalToolExecutionTimeout derived from bifrostConfig.client_config.mcp_tool_execution_timeout (fallback 30) and used it as the input placeholder instead of the hardcoded "0".

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Affected areas

  • UI (React) — MCP client edit sheet

How to test

  1. Open the edit sheet for an MCP client with no per-client Tool Execution Timeout set.
  2. Confirm the placeholder now shows the real global default (30 by default, or the configured mcp_tool_execution_timeout value) instead of 0.

Screenshots

N/A — placeholder text change only.

Breaking changes

None.

Security considerations

None — display-only change.

Checklist

  • Verified locally (tsc --noEmit passes for the changed file)
  • No unrelated changes

…holder

Fixes maximhq#5027. The placeholder was hardcoded to 0 instead of reflecting
the fetched global default (30s), unlike the sibling Tool Sync Interval
field which already does this correctly.
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Added a globalToolExecutionTimeout value derived from bifrostConfig.client_config.mcp_tool_execution_timeout with a default of 30, replacing the hardcoded "0" placeholder for the "Tool Execution Timeout (seconds)" input field in the MCP client sheet.

Changes

Tool Execution Timeout Placeholder Fix

Layer / File(s) Summary
Global timeout placeholder derivation
ui/app/workspace/mcp-registry/views/mcpClientSheet.tsx
Derives globalToolExecutionTimeout from config with a fallback of 30 and uses it as the input placeholder instead of the hardcoded "0".

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • maximhq/bifrost#4472: Introduced the per-client Tool Execution Timeout override field in the same mcpClientSheet component that this PR fixes the placeholder for.

Suggested reviewers: Pratham-Mishra04

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The change matches #5027 by showing the real global tool execution timeout placeholder instead of 0.
Out of Scope Changes check ✅ Passed The PR only updates the MCP client sheet placeholder and introduces no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title is concise and accurately describes the main change: fixing the MCP tool execution timeout placeholder.
Description check ✅ Passed The description covers the required template sections with summary, changes, type, affected area, testing, screenshots, breaking changes, security, and checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot requested a review from Pratham-Mishra04 July 9, 2026 03:58
@greptile-apps

greptile-apps Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The change is display-only and keeps the existing form value handling intact.
  • No test IDs, security paths, or backend config writes were changed.

Important Files Changed

Filename Overview
ui/app/workspace/mcp-registry/views/mcpClientSheet.tsx Adds the fetched global tool execution timeout to the MCP client sheet and uses it for the timeout input placeholder.

Reviews (1): Last reviewed commit: "fix(ui): show real global default in MCP..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: MCP client "Tool Execution Timeout" placeholder shows 0 instead of the real global default (30s)

2 participants