fix(ui): correct MCP tool execution timeout placeholder#5045
Open
Shaik-Sirajuddin wants to merge 1 commit into
Open
fix(ui): correct MCP tool execution timeout placeholder#5045Shaik-Sirajuddin wants to merge 1 commit into
Shaik-Sirajuddin wants to merge 1 commit into
Conversation
…holder Fixes maximhq#5027. The placeholder was hardcoded to 0 instead of reflecting the fetched global default (30s), unlike the sibling Tool Sync Interval field which already does this correctly.
Contributor
📝 WalkthroughWalkthroughAdded a ChangesTool Execution Timeout Placeholder Fix
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ui): show real global default in MCP..." | Re-trigger Greptile |
R-droid101
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5027
Summary
Small fix: the Tool Execution Timeout field placeholder in the MCP client edit sheet was hardcoded to
0instead of showing the real global default (30), unlike the sibling Tool Sync Interval field which already reflects the fetched global value.Changes
ui/app/workspace/mcp-registry/views/mcpClientSheet.tsx: addedglobalToolExecutionTimeoutderived frombifrostConfig.client_config.mcp_tool_execution_timeout(fallback30) and used it as the input placeholder instead of the hardcoded"0".Type of change
Affected areas
How to test
30by default, or the configuredmcp_tool_execution_timeoutvalue) instead of0.Screenshots
N/A — placeholder text change only.
Breaking changes
None.
Security considerations
None — display-only change.
Checklist
tsc --noEmitpasses for the changed file)