Repository navigation
PlotlyFigure: buttons and sliders in the site's colours - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An animation's Play button and slider (
updatemenus,sliders) were drawn in Plotly's defaults: white, with the light text of dark mode, so they could not be read.themeControls(inlib/plotly-theme.ts, with tests) gives the buttons and sliders the page's colours: text,--sl-color-gray-6background, hairline borders, and the accent for the dragged handle. They follow the theme toggle like the rest of the figure.type: "buttons") getshowactive: falseunless they set it themselves. Plotly draws the active button in a fixed light blue, which a Play button doesn't need.I checked this on the example animation of the maxplotlib "Web figures" guide (max-models/maxplotlib#89), in light and dark mode.
npm run test:js: 84 passed.