Repository navigation
Docs: interactive figures on the theme's PlotlyFigure - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interactive figures of the guides are now web figures shown by the docs theme's
PlotlyFigure(starlight-theme 0.8). The site's ownPlotlyChartis removed.generate_docs_figures.py,generate_gvec_figures.py,generate_desc_figures.py) writepublic/plotly/<name>.plotly.jsonthroughPlotResult.save(Save plots as web figures for the docs theme #97). The two figures made directly in Plotly (the hand-built slice and the profile Gantt chart) go throughPlotResult(fig).savetoo.<PlotlyChart src=… height=…>in the guides become<PlotlyFigure src="….plotly.json">. The page reserves each figure's space from its aspect ratio, so the fixed heights are gone.white_plot), asPlotlyChartdid. The other colours follow the theme..plotly.jsonin an MDX page.Checks:
generate_docs_figures.pylocally: all 21 of its figures are written, with an aspect hint, and the animations keep their frames. The GVEC and DESC figures need those packages and are generated in CI.