Repository navigation
Keep Matplotlib's global rcParams when a canvas is drawn - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drawing a canvas with Matplotlib changed the global
rcParamsfor good:setup_tex_fontsandsetup_plotstylewrite serif fonts, inward ticks, dotted grids and the canvas font size intoplt.rcParams. Every figure drawn afterwards in the same process got that style, including figures of other packages. plasma-plots' docs, for example, had serif fonts on every figure drawn after a scope-profiler chart.What changes
plot_matplotlibdraws insideplt.rc_context(), so the globalrcParamsare the same afterwards. The canvas figure still gets its style, because fonts, ticks and grids are fixed when the artists are created.rcParamsthe style changed.savefigandshowapply them again while saving and showing, so LaTeX text, which reads the font family when it is drawn, still renders with the canvas fonts.setup_tex_fontsonly for its side effect on Matplotlib. It now runs insiderc_contexttoo.Tests