Add useRefs hook#17
Open
rimuy wants to merge 6 commits into
Open
Conversation
Ukendio
requested changes
Feb 10, 2024
Ukendio
left a comment
Member
There was a problem hiding this comment.
It needs some tests, primarily because it is new and unproven API but also want to see examples of how it would be used in several scenarios.
LastTalon
requested changes
Feb 11, 2024
LastTalon
left a comment
Member
There was a problem hiding this comment.
Could you link this to an issue to discuss the actual use case of this hook?
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
As your game UI grows, it becomes really difficult to track the instances you want to filter the references - If I had a tree of functions that returns instances, and want to capture one of its descendants, I'd have to pass my
reftable all the way down the tree just so I could set the reference to be that one instance.The proposed new hook called
useRefs, eliminates this issue by grabbing thereftable in the currentuseInstancecall. This can only be used insideuseInstanceand will error if done otherwise.Additional comments
useInstance's callback.reftable afteruseCallbackis done executing as it shouldn't be mutated anyways. (New hook's behavior also depends on this)