Repository navigation
Conversation
Add RequestDeviceVerification to the client API so a test can verify another user's device, and TestVerificationSASOtherUser, which verifies Bob's device from Alice's, across servers when the client matrix asks for it. The JS client implements it with requestDeviceVerification; the Rust FFI cannot yet, so it skips. RequestOwnUserVerification relied on the request coming back to the sender, which only happens when the sender does not know its other devices yet and sends to '*'. When it already knew them, the request was never tracked and TestVerificationSAS timed out after the receiver became ready. Track the sent request directly and ignore received requests we initiated. Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RequestDeviceVerification to the client API so a test can verify another user's device, and TestVerificationSASOtherUser, which verifies Bob's device from Alice's, across servers when the client matrix asks for it. The JS client implements it with requestDeviceVerification; the Rust FFI cannot yet, so it skips.
RequestOwnUserVerification relied on the request coming back to the sender, which only happens when the sender does not know its other devices yet and sends to '*'. When it already knew them, the request was never tracked and TestVerificationSAS timed out after the receiver became ready. Track the sent request directly and ignore received requests we initiated.