feat(node): Upgrading NodeJS version to 24#243
Conversation
7adbd55 to
a6e6e85
Compare
|
Okay now it works, tested it with only: - name: Get Bot App Token
uses: actions/create-github-app-token@v2
id: app_token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
- uses: actions/checkout@v6
with:
token: ${{ steps.app_token.outputs.token }}
- run: |
git config user.email "ID+USER[bot]@users.noreply.github.com"
git config user.name "USER"
- name: Autotag
id: tag-pr
uses: nickkostov/github-tag-action@feat/upgrade-nodejs
with:
release_branches: develop
default_bump: ${{ steps.labels.outputs.bump }}
github_token: ${{ steps.app_token.outputs.token }} |
|
@mathieudutour how do we proceed now? |
|
Would love to see this make its way in. How can I help? |
I have it in my fork if you want to use it 😊 |
|
@mathieudutour any word on this? |
| # comment out in distribution branches | ||
| node_modules/ | ||
| lib/ | ||
| #lib/ |
There was a problem hiding this comment.
@nickkostov is this intentional? Seems that this is only meant for distribution branches.
There was a problem hiding this comment.
I don't remember, frankly I need to revisit this sometime soon.
Don't want to make any promises.
|
@nickkostov When I try to use your fork, I get the following error message. Any ideas? |
|
I will have to test it myself |
|
@nickkostov Ehh, never mind, I switched to the v1.3.0 release and it works :) |
Was going to suggest that but was afraid I would mislead you |
|
@nickkostov I just regret not thinking of that before I commented here 😆 Thank you for taking the time to fix that in a fork!! I hope @mathieudutour merges it before his version stops working completely! |
NodeJS 20 is deprecated as runtime in github actions. Bumped to 24.
Related to: #242