Skip to content

feat(node): Upgrading NodeJS version to 24#243

Open
nickkostov wants to merge 1 commit into
mathieudutour:masterfrom
nickkostov:feat/upgrade-nodejs
Open

feat(node): Upgrading NodeJS version to 24#243
nickkostov wants to merge 1 commit into
mathieudutour:masterfrom
nickkostov:feat/upgrade-nodejs

Conversation

@nickkostov
Copy link
Copy Markdown

@nickkostov nickkostov commented Mar 12, 2026

NodeJS 20 is deprecated as runtime in github actions. Bumped to 24.

Related to: #242

@nickkostov nickkostov force-pushed the feat/upgrade-nodejs branch from 7adbd55 to a6e6e85 Compare March 12, 2026 19:01
@nickkostov
Copy link
Copy Markdown
Author

Okay now it works, tested it with only:

      - name: Get Bot App Token
        uses: actions/create-github-app-token@v2
        id: app_token
        with:
          app-id: ${{ vars.GH_APP_ID }}
          private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
      - uses: actions/checkout@v6
        with:
          token: ${{ steps.app_token.outputs.token }}
      - run: |
          git config user.email "ID+USER[bot]@users.noreply.github.com"
          git config user.name "USER"

      - name: Autotag
        id: tag-pr
        uses: nickkostov/github-tag-action@feat/upgrade-nodejs
        with:
          release_branches: develop
          default_bump: ${{ steps.labels.outputs.bump }}
          github_token: ${{ steps.app_token.outputs.token }}

@nickkostov
Copy link
Copy Markdown
Author

@mathieudutour how do we proceed now?

@rjhill-bl
Copy link
Copy Markdown

Would love to see this make its way in. How can I help?

@nickkostov
Copy link
Copy Markdown
Author

Would love to see this make its way in. How can I help?

I have it in my fork if you want to use it 😊

@rking-bennie
Copy link
Copy Markdown

@mathieudutour any word on this?

Comment thread .gitignore
# comment out in distribution branches
node_modules/
lib/
#lib/
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickkostov is this intentional? Seems that this is only meant for distribution branches.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember, frankly I need to revisit this sometime soon.
Don't want to make any promises.

@PaddySe
Copy link
Copy Markdown

PaddySe commented May 7, 2026

@nickkostov When I try to use your fork, I get the following error message. Any ideas?

> Run nickkostov/github-tag-action@feat/upgrade-nodejs

node:internal/modules/package_json_reader:301
  throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
        ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@actions/core' imported from /home/runner/work/_actions/nickkostov/github-tag-action/feat/upgrade-nodejs/lib/main.js
    at Object.getPackageJSONURL (node:internal/modules/package_json_reader:301:9)
    at packageResolve (node:internal/modules/esm/resolve:764:81)
    at moduleResolve (node:internal/modules/esm/resolve:855:18)
    at defaultResolve (node:internal/modules/esm/resolve:988:11)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:697:20)
    at #resolveAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:714:38)
    at ModuleLoader.resolveSync (node:internal/modules/esm/loader:746:52)
    at #resolve (node:internal/modules/esm/loader:679:17)
    at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:599:35)
    at ModuleJob.syncLink (node:internal/modules/esm/module_job:162:33) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Node.js v24.15.0

@nickkostov
Copy link
Copy Markdown
Author

I will have to test it myself

@PaddySe
Copy link
Copy Markdown

PaddySe commented May 7, 2026

@nickkostov Ehh, never mind, I switched to the v1.3.0 release and it works :)

@nickkostov
Copy link
Copy Markdown
Author

@nickkostov Ehh, never mind, I switched to the v1.3.0 release and it works :)

Was going to suggest that but was afraid I would mislead you ☺️

@PaddySe
Copy link
Copy Markdown

PaddySe commented May 7, 2026

@nickkostov I just regret not thinking of that before I commented here 😆 Thank you for taking the time to fix that in a fork!! I hope @mathieudutour merges it before his version stops working completely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants