Skip to content

use blueprint for lpad gui#472

Open
tschaume wants to merge 23 commits into
materialsproject:mainfrom
tschaume:master
Open

use blueprint for lpad gui#472
tschaume wants to merge 23 commits into
materialsproject:mainfrom
tschaume:master

Conversation

@tschaume

@tschaume tschaume commented Jan 5, 2022

Copy link
Copy Markdown
Member

Converting lauchpad GUI to a Flask Blueprint to allow for it to be mounted at a different prefix/application root @mkhorton @shreddd

@mkhorton

mkhorton commented Jan 5, 2022

Copy link
Copy Markdown
Member

Thanks @tschaume. Can I confirm that, to your knowledge, there are no breaking changes in this PR?

@computron This PR is to allow us to more easily deploy FW dashboards for multiple people on NERSC infrastructure but should otherwise not affect dashboards for regular users.

@tschaume

tschaume commented Jan 5, 2022

Copy link
Copy Markdown
Member Author

@mkhorton There shouldn't be breaking changes but the commented-out part in fireworks/scripts/lpad_run.py needs to be tested.

@computron

Copy link
Copy Markdown
Member

@mkhorton @tschaume I'm trying to catch up on some PRs - could you let me know the current status of this? It looks like some tests are failing but maybe they just need a quick rerun or check

@computron computron added the stale Stale/abandoned PRs and issues label Feb 1, 2022
@tschaume

tschaume commented Feb 1, 2022

Copy link
Copy Markdown
Member Author

@shreddd and @mkhorton have used the blueprint successfully already I think. Based on what's in this PR, this part needs reimplementation to work with blueprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale/abandoned PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants