Avoid serialization loop with IndexMetadata during serialization#186
Conversation
7b5d89a to
184a77e
Compare
|
Hi @alexander-schranz Thanks for fixing this bug. It's really strange, because we've been using Sulu with the Search functionality for some time now and suddenly this bug appears. We don't use Categories. Doing a data dump inside the infinite loop it it serializing metadata for Account. However, in terms of data or metadata nothing has changed, so I can't explain this issue suddely appearing. Do you have any clues? |
|
Hi @matthiasnoback, I think it happens during creating the metadata, so I think even if you don't use the categories. Suddenly appears in this case means you did get newer versions of PHP on your System. By maybe using If you run in all versions https://3v4l.org/40nda you see it worked well before 8.3.27 and 8.4.14 but fails on the new one. I created an issue there: php/php-src#20338. But not sure how they will handle it. For us it needed to be a quickfix as it crashed several PHP installation so we avoided the index loop. To be sure, updating the MassiveSearchBundle did fix it also in your project? |
|
Thanks, @alexander-schranz ! Of course, implicitly updating PHP 8.3 while building the Docker container can explain this. Indeed, updating the bundle fixed it. |
Issues appear during saving a category or similiar in sulu admin the metadata serilaization ending in:
Or for others as reported
PS: Issues is related to the newly released versions of PHP 8.3.27 and 8.4.14, see php/php-src#20338, PHP versions before are not effect by the bug, but update still recommended.